[_ck_]

I forgot to add the topic_id=12 and group by on my queries sorry.

Well the numbers are coming from post position.

But still something is very wrong, because bbpress is showing 81 as the post count.

You need to run the exact query that the recount function uses.

SELECT topic_id, COUNT(post_status) as topic_posts FROM bb_posts WHERE post_status=0 AND topic_id=12 GROUP BY topic_id

See if that gives 80 or 81

[e-motion]

This query gave me an error:

#1140 - Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause

So I just did this:

SELECT * FROMbb_postsWHERE topic_id=12

And the result is:

Showing rows 0 – 29 (80 total, Query took 0.0020 sec)

So now I’m wondering where is bbpress taking post count numbers from?

[e-motion]

I do know how to use it. I just can’t recall if I messed with it relating bbpress before this happened.

[_ck_]

Okay I see the problem now with the next page link on page 4, which takes it to an empty page.

That in theory is a slightly different problem.

We can see that bbpress thinks there are 81 posts (visible) in the topic.

And there are 20 posts per page on the default setup.

So yeah, there should be a page 5.

Somehow post 81 is showing on page 4

page 1: 1-20

page 2: 21-41 <<<< mistake, post-position 24 is missing

page 3: 42-61

page 4: 62-81

Something started going wrong on page 2 I think?

It should start at 21 and go to 40.

Let me go back and look at that.

Yup, there is a gap for 23-25

That means that number count is showing post-position and 24 has been deleted.

So the example I show above with the pages, imagine post 24 is post 4 from the example.

bbPress is being stupid and rounding up for some reason.

There aren’t 81 posts in the topic, there are 80.

[mr_pelle]

What version of bbPress are you on? There is no $end at line 244 of that file, neither on the BackPress version shipped with bbPress 1.0.2 neither with trunk…

[e-motion]

I am now trying to recreate the problem. I was unable to do so on new topic and can’t remember exactly what I did last time. It just recounts all post numbers and everything works fine. It is stupid of me, but somehow I think that I may have tampered with the post physically – on phpMyAdmin. I am not sure about this, I do lots of stupid things.

I have now temporarily closed this topic (it is most active one in my whole forum) and added some posts to replicate the problem:

http://e-motion.lt/bbpress/topic/12?replies=80&message=closed

Forum says there are 81 posts and 5 pages. On page #2 post #24 is missing.

Page #5 is “empty”. If I unlock the topic, reply form is on page #5 and not #4, where the last post is.

Sorry, I am not so good with CMS-related stuff.. I do know some PHP and MySQL, but some basic help may be needed.

P.S. Very nice to hear you also have an e-bike! I have been riding this one for a while: http://www.youtube.com/watch?v=fXsE5NNfC7w

And hopefully will ride a DIY electric scooter in couple of weeks.

[_ck_]

I have a little trick to workaround this problem, at least when bbpress requests a link for the post that happens to be the last post in the topic.

I will write a filter for when get_post_link is requested, it will check the post id# – if it happens to be the last post in the topic (stored in topic_last_post_id) it will instead route the request to the more accurate get_topic_last_post_link

[_ck_]

Here’s a simplified example of what I think is happening internally.

Let’s say for ease of understanding there are TWO posts per page.

And there are 7 posts in this particular topic example

|1 2| – |3 4| – |5 6| – |7|

so there are 4 pages (each | | is a page)

In this example, the post numbers are also the post-position.

Now let’s say a mod deletes post number 4

|1 2| – |3 5| – |6 7|

Should only be three pages.

But bbPress is stupid by default, post-position is never recalculated so those post numbers still represent post position in this example.

bbPress DOES track number of posts in a topic, even when deleted.

So requesting a link to the last post in the topic, regardless of post-position, WILL be calculated correctly, and return page 3.

However, if it specifically asks for a direct link to post 7 and not the last post in the topic, this is what happens.

Post 7 is post-position 7

posts per page is 2 per page

ceil( $post_position / $per_page )

7 / 2 = 3.5, ceil of 3.5 = 4

So it will ask for page 4

Page 4 does not exist in the topic.

The link may be created but the link is bogus and will not work, it will either return you to the first page of the topic, or maybe the front page of the entire forum.

[alecasadei]

Hi everyone,

I’ve been running my BBpress for a couple of years now and just recently, I got an error that doens’t allow me to do access it anymore.

Here is the url: http://www.iamforeverfit.com/forum

Can somebody help me? I have no clue what’s going on?

Thanks,

Ale

[_ck_]

You know what, this is an inherit flaw with bbpress that I think I mentioned elsewhere years ago.

It never recalculates post-position when there are deleted posts, yet it relies on that post-position to find a specific posts’s page.

See this is how it calculates the page

function get_post_link( $post_id = 0 ) {

$bb_post = bb_get_post( get_post_id( $post_id ) );

>>>>>>	$page = bb_get_page_number( $bb_post->post_position );

return apply_filters( 'get_post_link', get_topic_link( $bb_post->topic_id, $page ) . "#post-$bb_post->post_id", $bb_post->post_id );

}

and this is how it calculates that page

return intval( ceil( $item / $per_page ) );

so it’s $bb_post->post_position / $per_page

always, regardless if there are deleted posts in the way, which is why it can be “short” when calculating the last page(s) on a longer topic with deleted posts.

The solution is that post-position has to be recalculated when a post is deleted. The only side effect is that for admin, jumping directly to a deleted post would not work, you’d have to find it manually.

bbPress never, ever, re-calculates post-position, even on a recount, if I am not mistaken.

There is one tiny work-around we can do.

For the LAST POST calculation, we can intercept that and subtract the number of deleted posts from the post-position. Hmm, actually wait, is it subtract or add. I have to investigate this a bit and think out the logic.

[_ck_]

I must be missing the problem here.

The “latest reply” link works.

When I am on page 3, the page 4 link works.

What specifically is not working?

Are you saying the problem is intermittent?

ps. I use an ebike with a custom lifepo4 battery

Oh wait, I see what you saying now

he problem vanished when one reply was written.

It will reappear when someone writes a reply last on that page.

so it’s an even/odd problem

if there are an even number of posts, it works,

if there is an uneven number, it does not work

Did you try the trick of deleting one post and then undeleting it?

There must be a bug in the way bbPress calculates post-position when there are deleted posts. I wonder if it’s specific to 1.x

[e-motion]

No, I do not. I have following plugins:

Akismet

Allow Images

Avatar Upload

BBcode Buttons Toolbar

BBcode Lite

bbPM

BBVideo

Bozo Users

Hello Louie

Human Test for bbPress

Instant Password

Skip Akismet

SourceCode Highlighter

[jdeleon]

Hi Guys

My bbpress install brings up the following error message now

—

Internal Server Error

The server encountered an internal error or misconfiguration and was unable to complete your request.

Please contact the server administrator, cgiadmin@yourhostingaccount.com and inform them of the time the error occurred, and anything you might have done that may have caused the error.

More information about this error may be available in the server error log.

—

Would anyone know how I would fix this? It was working fine only until a week or two ago when this error now appears.

Cheers

[John James Jacoby]

@erlend – Understandable. Will try to do better.

@mbiernat – Thanks for the pat on the back. Definitely helps to have some support

[Ashish Kumar (Ashfame)]

Does this plugin work flawlessly or it has some issues in the long run or anything else for that matter?

http://bbpress.org/plugins/topic/wordpress-bbpress-syncronization/

Would like to hear from someone who has been using it for quite some time.

[kikko088]

Hi at all, I have a question, I’m use avatar upload on my bbpress installation, it work very well, the problem is that I put this string on profile.php

<?php avatarupload_display($user->ID); ?>

for display avatar on profile page but I can see only my avatar, if I’m looking another user avatar I can’t see it…

How can I do for see the avatar of all the user instead only my avatar?

Last question, there is a way for hide favorite page to common user as edit profile page?

kikko088

[mbiernat]

JJJ, I think everyone sincerely appreciates your work and dedication. I have been looking forward to the BBpress plugin, but I think it is pretty understood Sept 15 is a very soft idealistic date. Again thank you for the work you have and will put in on this.

[Erlend]

Thanks for the update John. I’ll admit I had already adjusted my expectations. Here’s the thing about transparent development and deadlines though: It’s fine to set deadlines, but when you’re getting a strong sense that you won’t make it, say so.

I would have preferred checking in yesterday or the day before that to find “bbPress pre-release deadline post-poned”. Instead I came in today with just a tiny bit of hope, but we all know how that ended.

@_ck_ The “hijacking” comment was all kinds of ‘too far’, ‘out of context’ and plain false. I have a lot of respect for you and share a lot of your opinions about the bbP project, but right now you are truly on the verge of trolling.

[lmsook10]

Hello,

I’m new in both WP and BBP, but have some background with PHP.

I’m building a website using WP 3.0 Twenty Ten theme, and one of page needs bulletine board, so I decided to use BBPress for that.

Thanks for http://1plusdesign.com/articles/bbpress-wordpress-integration/ I could install bbpress under my WP site (http://localhost/wordpress) like http://localhost/wordpress/forums and if I go to http://localhost/wordpress/forums directly, I can see the bbpress forum, but my question is without direct accessing to the url (http://localhost/wordpress/forums),how can someone from my WP site go to the forum page? For instance, I have a page called Forum in my WP site, and I would like if someone clicks(goes to) the page, it will display http://localhost/wordpress/forums

Thanks for your reply.

[_ck_]

Yes but what happens when you try to jump directly to a specific post.

bbPress doesn’t know the order of the posts so unless you change it with a filter, it will never return the person back to their own post.

If you only have a single page of posts the problem is avoided, but try it on a topic with three pages of posts.

[_ck_]

Mods have no control over that and I highly doubt admin will bother because of display names giving you the ability to rename anyone to anything else.

Asking on bbpress.org is probably also a bad idea, use the more highly trafficked wordpress.org

[hpguru]

Feature request: Import from bbPress (should be coming) and Simple:Press. Thank you.

[Rich Pedley]

All sounds good, thanks for the update

[John James Jacoby]

I’ve been side tracked with BuddyPress bugs and paying work, so don’t expect anything official for a week or two. I have a few projects coming up fast that will need this working so while I’m missing my soft Sept 15 deadline, I don’t think it will be /too/ far off.

Sorry to disappoint, it’s no fun… and thanks for your patience with me and it.

For the record, I love bbPress. I have a few commits going into 1.1, and I have every intention of making bbPress be the best it can be as a WordPress plugin.

Regarding my motivation and priority, it’s to make great forum software that fits inside WordPress; nothing more and nothing less.

Regarding why I was able to step into this role, it’s because our peers believe I am capable, and I am willing to dedicate time and effort towards it getting it done.

Regarding any possible benefit BuddyPress might see, is a welcome bonus but not a priority. BuddyPress/bbPress processing times should decrease with BuddyPress 1.2.6, as a few tweaks have been made and a bug or two have been patched in that regard. Even still, nothing compares to the blazing fast speed of bbPress by itself, even in the slower 1.x branch.

Regarding everything else, I’m just here to write the best code I can, help make bbPress a great WordPress plugin, and have fun doing it all. So far, so good on my end.

[milkyWim]

solved! see : https://bbpress.org/forums/topic/making-the-newest-posts-show-up-first