[mazdakam]

here is my pack there is some modification for translating in hard code

https://opensvn.csie.org/wppersian/bbpress/files/poll.zip

[_ck_]

Good advice and very clear points. Not worth the risk.

I’ve been looking at some of their templates and it’s not that amazing anyway. They also use tables. If I clear up my layout and document it well, I am sure some css gurus out there can make something even better.

In other news I fixed the nagging refresh bug

http://ckon.wordpress.com/files/2007/08/bb-polls.txt?v018

(the post data that’s left on the page when you hit f5) but I hate the way it has to be done (redirect after processing the post data, back to the same page – that’s twice the load for bbpress – can’t find any other documented solutions).

I think my next code attempt will be to make it load in place (like ajax but not really ajax).

[_ck_]

The CSS is fully editable for the bar colours. You can even make the bars fancy images if you so desire.

I guess I am going to have to make a proof-of-concept to show people that it doesn’t have to look anything like my default. I can even make it look like polldaddy.

ps. @fel64 v0.17 now tricks bbpress in keeping the poll data completely unserialized until the plugin actually needs it (easy fix). It still has bbpress cache the data with the topic for fast loads. What’s nice about this is the topic title “[poll]” can still tell if the topic has a poll by just checking for the object without deserializing it (ie. $topic->poll_options) – oh it’s also completely compatible with any currently saved poll data and can deal with it already being unserialized, it just fixes it on the next vote

[_ck_]

example of when serializing is bad:

a loop of 50 topics being displayed where the data has to be unserialized each and every time because of the way the data is fetched – it’s very easy to accidentally make this happen

fortunately polls are only displayed on the topic page where the data has already been fetched from the db and deserialized once

What bothers me even more however is using things like is_topic() which can get caught within the topic list loop on the front-page/forum page, because of how much work it does and how repetitive it is without being cached.

Unfortunately I cannot figure out a less intensive way and it can’t be cached. bbpress should be storing a simple string flag for it the moment it determines its heading towards that template, not post-processed by looking at the filenames. The difference in overhead is significant.

ps. actually, I just realised I am doing that bad version of deserializing. I have to trick bbpress not to deserialize all that data… will work on it

[fel64]

Serializing data is only bad if you are going to be constantly unserializing it in the same bbpress instance.

_Anything_ is bad if you do it unnecessarily. I don’t understand why you were unhappy with serialising earlier in this case.

Obviously topicmeta is there to be used for topicmeta. That doesn’t mean it needs to store everything that could be construed as topicmeta. My question wasn’t what where the orthodox place to store topicmeta was, but a comparison of unserialising very large arrays vs. a single query. But then I think that serialising is linear, anyway, so it probably remains very good value.

[Null]

The trac discussion:

https://trac.bbpress.org/ticket/633

[Null]

Well made a ticked of this

https://trac.bbpress.org/ticket/718

[_ck_]

One thing that’s probably holding that back and bugs me in that templates are not re-used in bbpress, is for example how post-form and edit-form should be integrated with maybe one or two conditional statements if necessary.

I guess ajax post deletes are a lot easier than ajax posting/editing.

Then there is the code block in front-page, forum.php & view.php which shows sub-forums, stickeys and posts. It’s virtually identical in each template but if you want to change one, you got to go to all three and change them in each place, the exact same code. It should be a sub-template, which of course I could hack in on my own but should be part of the core. Change it in one place, changes everywhere you see it.

[_ck_]

“get_topic_last_post_link()” and it’s dependency “get_post_link()” relies on two important things which can be easily thrown off in bbpress or it’s db

1. if you are using a plugin or other code to change the number of topics shown on the front page or forum pages vs the topic page, get_topic_last_post_link() will calculate the last post incorrectly. This is because there is only one universal setting in bbpress right now for the number of items per page (there should be an array in the core so limit can be different than limit and then get_topic_last_post_link() will know to look at the destination limit instead of where it’s coming from)

see my bug fix for custom limits for each page here:

https://bbpress.org/forums/topic/custom-topics-count-for-different-pages-that-doesnt-break-last-post

it basically forces get_post_link to recalculate

2. get_topic_last_post_link() relies on the post_position in the bbpress table – which can get messed up if there are deleted posts, moved/merged posts, or recounts

Recounts does not attempt to recalculate and resave the post_position. This would have to be written. It basically would have to look at all posts in a topic, sort them by the desired date order, and then renumber them.

[chrishajer]

Looks like it happened around r406 to address trac ticket 425? (the last place I can find topic-ajax.php is r384):

https://trac.bbpress.org/browser/trunk/bb-admin/admin-ajax.php?rev=406

https://trac.bbpress.org/ticket/141

09/22/06 20:47:15 changed by mdawaffe



* status changed from assigned to closed.

* resolution set to wontfix.



We're not even ajax posting anymore.

Should revisit this if we ever go back.

[_ck_]

Actually originally in my code, I was unserializing the data ONCE, then the array is passed globally, already in place. Serializing data is only bad if you are going to be constantly unserializing it in the same bbpress instance. I don’t do that (on purpose).

(update, actually I have to go back and fix the process with that, I did a quick fix around a bug and fetched $topic each time but that needs to be a global also – all the code used to be in one routine so $topic was only fetched once, but that’s changed – I can fix)

I used meta data because that’s what it’s there for. There is no need on a forum to create extra tables for stuff that won’t be used outside bbpress. I look at all the downsides of poll plugins like WP-Polls and tried to avoid them.

The goal was to use bbpress routines wherever possible for future tweaks. As I go back and cleanup bits of code I can already see where and how to make it more ajax-like (though that’s not a priority).

[dawnsbrain]

Yeah, it’s pretty niche, but there are a lot of art teachers out on the web, and not a whole lot of places for them to converse. bbPress has allowed me to provide the hands-down best-looking and best-behaving forum for them. I’m doing my best to get the word out now. I’ve had a few bites, but it’s slow-starting. Any ideas for further promotion would be much appreciated.

artteacherforum.com

Dawn Pedersen

Web and Graphic Design Teacher

Grades 9 -12

Sacramento, CA

[M]

Hmmm. Let me take a look.

Either $r1 and $rw need to be switched, or $r1 isn’t an array.

Edit:

Lines 358 – 360 should contain the following:

$r = (array) $bbdb->query( "SELECT * FROM ~$bbdb->menu~ WHERE ~set~ = 'active' ORDER BY ~order~ ASC" );



foreach( $r as $rw ) {

Replace the ~ with backticks. I don’t know how to escape backticks in bbPress.

[Null]

Hmmm got this error:

Warning: Invalid argument supplied for foreach() in /home/sites/site116/web/bbpress/my-plugins/bbmenu.php on line 390

the foreach:

foreach( $r1 as $rw ) {

Null

[_ck_]

I highly doubt most bbpress installers will continue to use the default template longer than a week or two. It’s a very sterile 1990’s computer room look, green/white, wide & empty. Ugh.

Reminds me of that old school continuous computer paper:

http://www.jwodcatalog.com/imgLg/753000NIB0342.jpg

I can’t wait until bbpress gets some critical mass of users so we have all those thousands of creative wordpress folks slaving away on themes.

---

On a programming note, I’ve got to figure out how to trash the post data that’s sent so when doing a refresh after voting the browser doesn’t nag the member that the post data will be resent (it won’t affect the poll stats if it does but still I don’t want that post data there). Probably have to do a redirect after submit which is a shame as it has to load bbpress twice then.

[aslan41]

hi

[_ck_]

Ah I see.

Well everyone can work on making it pretty – it’s very easy to do and I’ve laid it out fairly cleanly (css at the top).

As far as ajax, this will be my learning project, I only know the basics. But I have a strange style in that I like simple = better, so I’ll have to do some research. I also want to use the default bbpress javascript libraries unless I can do it somehow without dependencies.

Fortunately I have an idea on how to do it. Don’t hold your breath though, might be a couple weeks or more.

[mazdakam]

You should really change the default colors to something compatible with bbPress… it’s easy to change them, but still.

i agree with i! vey bad color

[howtogeek]

It works!

You should really change the default colors to something compatible with bbPress… it’s easy to change them, but still.

Very good work otherwise… I’ll play with it some more.

[raumgleiter]

I have the integration working. Got wordpress in the root and bbpress in a subfolder called /forum.

When I register on wordpress, the user is displayed as subscriber in WP and as member in bbpress. so all is correct.

But if I register on bbpress, then the user is “member” in bbpress but in WP it gets no role at all.

Second problem is that bbpress doesnt seem to send out any confirmation email although I can see new users in the backoffice.

BOTH plugins are installed and seem to be working fine.

[_ck_]

Since I can’t edit the first post here I’m just going to use my wp blog for updates:

bbPress Polls plugin

v0.11 is a bug fix:

http://ckon.wordpress.com/files/2007/08/bb-polls.txt?v011

[_ck_]

Installing it will definitely answer all your questions.

Many answers are yes. The current options near the top will give you an idea.

I designed it from the start to allow votes on multiple selections or single section – the poll creator can decide.

bbpress cleans up the topic meta on its own, so if the topic is deleted in theory the meta is deleted (but bbpress doesn’t really delete topics yet, it just flags the differently)

you can decide if polls close with the topic or not

you can also decide if the poll is shown on each page of the topic or just the first

only members can vote – I do not have any plans to implement non-member voting, it defeats the purpose and makes the code much more complex

Eventually I will do more than horizontal bars which will make a higher load (I am sure I can find an existing easy library). Bars are currently done in pure CSS which makes it lightning fast and completely customisable with colours and even rounded corners with images.

[Null]

Some questions:

Vote, more then 1 option possible option? (max setting like classic (just 1 option possible) 2 options, 3 etc

If a topic is deleted, does it clean-up the poll as well? (since a real deletion isn’t happening in bbPress, this wouldn’t be a problem for now)

What happends if a poll is deleted? (but topic still excists)

Who can vote? All? Members?

If a topic is closed, automaticly close voting aswell?

Results are in horizontal bars? Perhaps option to show them like a pie (or even vertical bars) Even better if a user can choose this when seeing the results:

Option result 1: ===============

Option result 2: =====

Option result 3: =========

Show as bars | Show as pie

Would like to see a demo, cause can’t test this at work

Greetz

[_ck_]

Oh… you’re hacking the core, that’s easy but not good.

I am desperately trying not to touch the bbpress core which was a huge mistake I did with wordpress and made it impossible to upgrade even when there were critical security fixes.

bbpress is in such a state of flux right now it would be crazy to hack the core, updates with major changes can be expected almost every other month.

I’ll put this on my scary growing list of things to look at. To be honest it’s not a huge priority but you might want to seriously consider my idea of messing with the topic_status flag. You already are halfway there.

[_ck_]

I am pleased to announce a new bbPress Polls plugin.

Your members can now add polls to their topics, or optionally you can allow *anyone* to add a poll to *any* topic, within a specified time period (hours) since the topic was started.

bb-Polls allows single answer or multiple answer polls.

No template edits of any kind.

There are no additional db tables added, it uses bbpress topicmeta only. Only one entry is created per poll, regardless of size or options (this allow very easy cleanup if desired for some reason).

This is a *very* early beta, however should be functional except for:

1. missing admin menu (coming soon – edit plugin directly)

2. missing administrative editing of existing polls.

3. missing some visual tweaks (plural case, etc.)

4. missing some more deluxe options (poll ending time, etc.)

5. missing multi-language support (coming soon)

If you can live with these limits and would like to help test and give me some useful, constructive feedback, please download:

http://ckon.wordpress.com/files/2007/08/bb-polls.txt?v010

(rename .txt to .php, install, activate, start a new test topic)

The beta is set so only moderators and above can create/see the polls. This will allow you to test without disturbing visitors.

Please note the visual styles may be WAY off for the default template or your own template. Unfortunately I am using a very customised template. You’ll probably have to edit the built in css which is kept clearly at the top. (the default styles will be fixed soon when I get a chance to do a trunk install this week)

Upcoming features include the ability to display all polls and the ability to display a poll anywhere within bbpress templates.

ps. I need to know if this works as in in the trunk version – I don’t see why it wouldn’t but you never know…