[fel64]

I’m _not_ saying it’s better. It could be. I’m just wondering about other people’s thoughts and reasons on optimising this.

[Null]

Got proof it had ajax posting….

From the automattic site:

All the features you need—like tags, AJAX posting, categorization, modular user system—and nothing you don’t.

We want it back

[fel64]

Can someone demonstrate what the polls are like? Has someone got one live to look at?

_ck_, you’re storing who voted for what in the topicmeta, right? You mentioned that unserialising stuff was a huge performance hit earlier, wouldn’t this be an issue especially with a large number of voters? What are your thoughts about implementing a bb_votes table to record who voted and how? (I’m not saying that’s better, I’m just wondering what your thoughts are on this because it interests me )

LOL! so why did everyone cry out for a poll plugin then?

I’m not sure everybody did.

[M]

Hmmm. Let me take a look.

Either $r1 and $rw need to be switched, or $r1 isn’t an array.

Edit:

Lines 358 – 360 should contain the following:

$r = (array) $bbdb->query( "SELECT * FROM ~$bbdb->menu~ WHERE ~set~ = 'active' ORDER BY ~order~ ASC" );



foreach( $r as $rw ) {

Replace the ~ with backticks. I don’t know how to escape backticks in bbPress.

[mazdakam]

yes i found these to your to do

: admin menu (coming soon – edit plugin directly)

: administrative editing of existing polls.

: multi-language support

[mazdakam]

_ck_ you move so fast!

i just play with the css and come but found that you make new one )

so it is now with better style thx but

please insert messages or strings in __() and _e() because it is prepare to fast translation with mo files

and if you put strings in these 2 function i can translate it in 2 minutes and it is good way for internationalistion

i think as you know we need to manage polls in admin area

and ability to select user to poll

and the creator of poll can edit the poll

also it will be very good if in frontpage we can see poll icon insted of [poll]

thanks for your great job

[_ck_]

I highly doubt most bbpress installers will continue to use the default template longer than a week or two. It’s a very sterile 1990’s computer room look, green/white, wide & empty. Ugh.

Reminds me of that old school continuous computer paper:

http://www.jwodcatalog.com/imgLg/753000NIB0342.jpg

I can’t wait until bbpress gets some critical mass of users so we have all those thousands of creative wordpress folks slaving away on themes.

---

On a programming note, I’ve got to figure out how to trash the post data that’s sent so when doing a refresh after voting the browser doesn’t nag the member that the post data will be resent (it won’t affect the poll stats if it does but still I don’t want that post data there). Probably have to do a redirect after submit which is a shame as it has to load bbpress twice then.

[Null]

Hmm kee, though I should release this plugin (when done) based on the default template (most are using that)

[Null]

ow make the text black (forum black) and not green, cause the hyperlink color is green already…

I also would put the options underneeth each other (the options to choose for single or multy voting)

(sorry I am an usability nerd )

Looks great further, keep up the good work

[_ck_]

Since bb-polls is completely css driven, you could actually make it look like any of theirs – with a few hours of work. Background images, submit button images, poll bar images – they all can be applied.

I think I’m doing enough work on the engine though. Someone else can spend the hours to skin it

[mazdakam]

You should really change the default colors to something compatible with bbPress… it’s easy to change them, but still.

i agree with i! vey bad color

[_ck_]

Installing it will definitely answer all your questions.

Many answers are yes. The current options near the top will give you an idea.

I designed it from the start to allow votes on multiple selections or single section – the poll creator can decide.

bbpress cleans up the topic meta on its own, so if the topic is deleted in theory the meta is deleted (but bbpress doesn’t really delete topics yet, it just flags the differently)

you can decide if polls close with the topic or not

you can also decide if the poll is shown on each page of the topic or just the first

only members can vote – I do not have any plans to implement non-member voting, it defeats the purpose and makes the code much more complex

Eventually I will do more than horizontal bars which will make a higher load (I am sure I can find an existing easy library). Bars are currently done in pure CSS which makes it lightning fast and completely customisable with colours and even rounded corners with images.

[Null]

Some questions:

Vote, more then 1 option possible option? (max setting like classic (just 1 option possible) 2 options, 3 etc

If a topic is deleted, does it clean-up the poll as well? (since a real deletion isn’t happening in bbPress, this wouldn’t be a problem for now)

What happends if a poll is deleted? (but topic still excists)

Who can vote? All? Members?

If a topic is closed, automaticly close voting aswell?

Results are in horizontal bars? Perhaps option to show them like a pie (or even vertical bars) Even better if a user can choose this when seeing the results:

Option result 1: ===============

Option result 2: =====

Option result 3: =========

Show as bars | Show as pie

Would like to see a demo, cause can’t test this at work

Greetz

[Sam Bauers]

I don’t think your code was correct in any case. But I’m not sure what the correct procedure is.

Apply the patch in the ticket (or make the changes manually) and try again.

[Null]

So I accedentily discovered a bug? :p Is the rest of my code correct? And how about: on plugin activation? Perhaps it has the same issue?

[Sam Bauers]

You also need to have the “bb_head” hook in your template head below the enqueue javascript call.

<?php bb_head(); ?>

[skipdaddyo]

Also in bb-includes/functions.php

function get_latest_topics – added $now and tweaked $where

$now = bb_current_time('mysql');

$where = "WHERE topic_status = 0 AND topic_start_time <= '$now'";

[skipdaddyo]

The names of the inputs on post-form.php are year, month etc

bb-includes/functions.php

new_topic becomes

function bb_new_topic( $title, $forum, $tags = '', $year, $month, $day, $hour, $minute, $second ) {

and $now

if ($year == NULL )

{

$now = bb_current_time('mysql');

}

else

{

$now = $year . '-' . $month . '-' . $day . ' ' . $hour . ':' . $minute . ':' . $second;

}

bb_new_post becomes the same

function bb_new_post( $topic_id, $bb_post, $year, $month, $day, $hour, $minute, $second ) {

and $now is calculated in the same way

[Null]

Hmmm got this error:

Warning: Invalid argument supplied for foreach() in /home/sites/site116/web/bbpress/my-plugins/bbmenu.php on line 390

the foreach:

foreach( $r1 as $rw ) {

Null

[Null]

Hi,

There is a hook so that, on plugin deactivation, you can do an action. In my case, I want to drop a table when the plugin is deactivated.

I can’t seem to get it to work. What am I missing?

The code:

function bb_deactivate_bbmenu() {

bb_register_deactivation_hook( bbmenu.php, 'drop_bbmenu_table' );

}



do_action( 'bb_deactivate_bbmenu' . $plugin );



function drop_bbmenu_table() {

global $bbdb;



$query = "DROP TABLE <code>$bbdb->menu</code>";



$bbdb->query( $query );

}

Also where does $plugin come from? Do I need to set it or does it grab the plugin’s name? And same about __file__ I used the plugins php file for this. Is this correct?

Some help plz

[fel64]

Alright. That makes it somewhat more difficult because I cannot tell what functions are called with that hook, but maybe it is possible to find out.

No post, you say? The mystery deepens.

Thanks for the phpinfo. Unfortunately OS X is somewhat difficult for me … perhaps I’ll be able to do this at a friend’s house. We shall see.

Cheers.

[LMD]

Just to confirm, version 0.8.1 is definitely now available to download — but the same “missing files” problem is still happening, so until it’s fixed, you’ll need to download the contents of the additional-files/my-templates/ and additional-files/avatars/* folders via the svn.

(* if you’ve already got a copy of the plugin, don’t bother to download the additional-files/avatars/content, it hasn’t changed.)

[_ck_]

I’d actually make this plugin for you as it doesn’t take much for it to happen – I just wanted to save some time by understanding how you are sending bbpress a predetermined future time and date rather than the current time and date for a new post. I haven’t looked at the core code but I didn’t think it was looking for time/date fields in a new post.

a quick look shows bb_new_post posting post_time as bb_current_time(‘mysql’) – so it’s not even checking if a different time has been submitted, it’s forcing it to use the time it calculates…

[_ck_]

The front page topics plugin was driving me crazy because I really did want to have a different number of topics for the front page, forum pages, view pages, while leaving the posts per topic page alone and not have to hack the core.

But there is a huge flaw in the fundamental design in that if you force bbpress to see a different number of topics-per-page, it will calculate the last post page entirely wrong, based on the page IT’S ON, vs the destination page.

ie. front page set to 50 topics, posts-per-topic-page set to 25, last post is #30 on the page -> bbpress will calculate the page number for the last post as PAGE ONE off the front page, because that’s what the topic count is set to for the front page.

This got me really annoyed so I researched the heck out of it and figured out this trick – it’s nasty but works (for 8.2.1 at least).

so in config.php you’ve got

// The number of topics that show on each page.

$bb->page_topics = 20;

now you can make a plugin with this, edit each page limit to your heart’s desire (anything without a $limit defined uses the config.php default)

function custom_topic_limit($limit) {

switch (bb_get_location()) :

case  'front-page':  $limit=45;  break;

case  'forum-page': $limit=35; break;

case  'tag-page':  break;

case  'topic-page':  break;

case  'feed-page':  break;

case  'search-page': break;

case  'profile-page': 	break;

case  'favorites-page': break;

case  'view-page': $limit=50; break;

case  'stats-page': $limit=50; break;

case 'login-page': break;

default:  $limit=20;

endswitch;

return $limit;

}

add_action( 'bb_get_option_page_topics', 'custom_topic_limit' );



function fix_post_link ($link,$post_id) {

remove_action( 'bb_get_option_page_topics', 'custom_topic_limit' );

$bb_post = bb_get_post( get_post_id( $post_id ) );

$page = get_page_number( $bb_post->post_position );

return  get_topic_link( $bb_post->topic_id, $page ) . "#post-$bb_post->post_id";

}

add_filter( 'get_post_link','fix_post_link',10, 2);

The magic is in fix_post_link where it trashes whatever incorrect calculation that “get_post_link” has now done because of custom topic limits, and relculates it after unhooking the custom_topic_limit.

No core hacks required!

[skipdaddyo]

template/post-form.php gets a section for normal users

<?php if ( !is_topic() && !bb_current_user_can('moderate') ) { ?>

and for mods

<?php } elseif ( !is_topic() && bb_current_user_can('moderate') ) { ?>

It’s in this section that I’ve added the year, month, day etc form fields

Sorry for the time it took to get back to you… Only just fired up my RSS reader…

I’d decided to kill off my main RSS feed (to get around the RSS visibility issue) and not to sweat over the post/topic count being out by one.