[Chuckie]

If I just have it top level, or top level and inside video at the same time, it strips the source tag and it’s contents from the video tag making it unusable.

The only way I can get the source tag and its attributes / contents to remain is if they are inside the video as an inner array, and only there.

[Chuckie]

This is the full function:

add_filter( 'bbp_kses_allowed_tags', 'ntwb_bbpress_custom_kses_allowed_tags' );

function ntwb_bbpress_custom_kses_allowed_tags() {
	return array(

		// Links
		'a'          => array(
			'class'    => true,
			'href'     => true,
			'title'    => true,
			'rel'      => true,
			'class'    => true,
			'target'   => true,
		),

		// Quotes
		'blockquote' => array(
			'cite'     => true,
		),
		
		// Div
		'div' => array(
			'class'     => true,
		),
		
		// Span
		'span'          => array(
			'class'     => true,
			'style'     => true,
		),

		// Paragraph
		'p'          => array(
			'dir'    => true,
			'style'  => true,
		),
		
		// Code
		'code'       => array(),
		'pre'        => array(
		'class'      => true,
		),

		// Formatting
		'em'         => array(),
		'strong'     => array(),
		'del'        => array(
			'datetime' => true,
		),

		// Lists
		'ul'         => array(),
		'ol'         => array(
			'start'    => true,
		),
		'li'         => array(),

		// Images
		'img'        => array(
			'class'    => true,
			'src'      => true,
			'border'   => true,
			'alt'      => true,
			'height'   => true,
			'width'    => true,
		),

		// Tables
		'table'      => array(
			'align'    => true,
			'bgcolor'  => true,
			'border'   => true,
		),
		'tbody'      => array(
			'align'    => true,
			'valign'   => true,
		),
		'td'         => array(
			'align'    => true,
			'valign'   => true,
		),
		'tfoot'      => array(
			'align'    => true,
			'valign'   => true,
		),
		'th'         => array(
			'align'    => true,
			'valign'   => true,
		),
		'thead'      => array(
			'align'    => true,
			'valign'   => true,
		),
		'tr'         => array(
			'align'    => true,
			'valign'   => true,
		),
		'video'      => array(
			'controls' => true,
			'width'    => true,
			'height'   => true,
			'source'     => array(
				'src'    => true,
				'type'	 => true
			)
		)
	);
} 

if I introduce source into the top level then the source inside the video tag gets stripped completely from the output. So I can’t do that. I think bbPress needs tweaking to stop escaping the video tag content. Some how. For not admin.

[Chuckie]

I am using the TinyMCE Insert Video plugin. I paste the URL into that. It works fine for admin. It is only non-admin.

My functions.php has some tags added to the array defined in here:

add_filter( 'bbp_kses_allowed_tags', 'ntwb_bbpress_custom_kses_allowed_tags' );

Snippet:

		'video'      => array(
			'controls' => true,
			'width'    => true,
			'height'   => true,
			'source'     => array(
				'src'    => true,
				'type'	 => true
			)
		)

There must be a way for me to allow those without escaping for non-admin.

The path begins https.

[Chuckie]

@robin-w

I am struggling with your other request. Something isn’t right. I have moderation still switched ON …

If I try to insert a video (only one video) as a non-admin and hit enter the video won’t play. When I edit the post the content looks like this:

<video controls="controls" width="300" height="150">
**source src="pathtovideo/pts-test-video.mp4" type="video/mp4" /**</video>

bbPress has escaped the < and > symbols.

If I log back in as admin and perform the same task. I get a functional video link:

<video controls="controls" width="300" height="150">
<source src="pathtovideo/pts-test-video.mp4" type="video/mp4" /></video>

I know it is a side issue but I don’t understand how to fix that and until I do I can’t complete the testing you wanted.

[Chuckie]

@robin-w I can confirm that:

add_filter( 'bbp_bypass_check_for_moderation', '__return_true' );

switches off moderating because I was able to insert 5 images as a normal user. So that is one item ticked off the list – how to switch off moderation.

I will now check the other.

[Chuckie]

I created a trac ticket here in the hopes this might get progressed more easily:

https://bbpress.trac.wordpress.org/ticket/3284#ticket

[Chuckie]

Here is a result of my particular situation. I think a feature in bbPress is now working correctly whereas it did not before.

If you go to your WordPress Settings | Discussion area there is an option to tell it when to flag a message for moderation based on the number of links. Mine was set to 2. This is why the users post was flagged. It had 3 links.

When I tried 2 links it still when to pending. When I tried with 1, it was accepted. I increased my limit to 4 and now it will accept 3 links. So that is one reason.

The second reason is inserting images (using MCE toolbar). It will not let the user insert more than one image into the post (unless they are admin). I do not know how to increase this as I would also like it to be capped at 4 but there are no settings provided for images. I think the same will apply for videos.

[Chuckie]

@johnjamesjacoby

Please look at the associated, more active discussion on this subject. There are lots of users who now have to approve every post. I have provided comments in that discussion instead.

I suggest you review that discussion. True, there are complaints, which are all to easy to roll of the tongue, but the point it things have changed. I don’t want to repeat my feedback so please see the other thread.

I personally need to find a way to control things going into pending. It should only do so if it thinks it needs moderation. Not all posts. The other discussion I found the function that changed the way posts are moderated so so thing must be askew there.

If your forum is working ok then are you on WordPress 5.3? What are your WordPress discussion settings set to for moderation? It might be an idea to become a admin on one of our sites. Best way to test because I expect this is a common solution.

See: https://bbpress.org/forums/topic/need-users-to-be-able-to-posts-without-posts-being-approved/

[Chuckie]

I had a lost at the differences between 2.5.4 and 2.6.1 for when it comes to moderation and I saw the new function. It is interesting that it refers to these hooks:

bbp_bypass_check_for_moderation

bbp_bypass_check_for_blacklist

Apparently you can use these hooks and if they return true it will stop performing the moderation check. I don’t know how to implement these hooks, and I am not telling anyone they should implement them. Moderation is a good thing when ti works as intended.

I had a look at my own WordPress Settings | Discussion Settings which is where I understand this gets all the behaviour from and my blacklist and whitelist are empty anyway. But I do have another checkbox ON:

Comments must be approved

I had that on because in my website posts where comments are allowed I wanted control. I don’t know if it is this checkbox that is the cause of every topic and reply needing moderation.

That said, in the same settings page in WP it has options for sending out an email whenever a comment goes into moderation and that is not honoured. So maybe none of these settings are taken into account?

[Chuckie]

I can confirm that a basic post with no attachments (reply) is going to pending. It did not before and would like this resolved please. I wish I could help.

Tied very closely to this is my other discussion where I have shown the code that displays moderation feedback to the user for new topics but the same code is missing for replies. It needs to be there. The user must be told there post has gone to the moderation queue. We have the code and phrases in the files. We just got to drop them into the replies mechanics (except it should go after the post and before the edit control.

Tied very closely with this is that by design the admin staff should be sent an email if a post goes to moderation without the need for external plugins. Atleast an option to do so.

Great plugin!

[Chuckie]

Hi @johnjamesjacoby

Do you think the feedback provided might be able to assist us in isolating the issue in 2.6.x?

Andrew

[Chuckie]

Sorted my issue. I forgot to add styling for bbp-topic-content classes! Doh!

[Chuckie]

I am using GD Power Search for bbPress and I think it is OK. The only thing for me is that some of the items in the list seem to have white text rather than black. Most have black text. If I go to the item in question via the link it shows with black text. So I don’t know why it changes.

[Chuckie]

I just found something out here ….

If I add a topic to a “public” forum then the freshness is fed back up the chain correctly.

If I add a topic to a “private” forum then the freshness is not fed back up the chain correctly.

Most of my forums are private.

Andrew

[Chuckie]

In the template.php file it has the following code:

	// Get the topic status
	switch ( $topic_status ) {

		// Spam notice
		case bbp_get_spam_status_id() :
			$notice_text = esc_html__( 'This topic is marked as spam.', 'bbpress' );
			break;

		// Trashed notice
		case bbp_get_trash_status_id() :
			$notice_text = esc_html__( 'This topic is in the trash.', 'bbpress' );
			break;

		// Pending notice
		case bbp_get_pending_status_id() :
			$notice_text = esc_html__( 'This topic is pending moderation.', 'bbpress' );
			break;

		// Standard status
		default :
			$notice_text = '';
			break;
	}

As you can see, it has specific notices for feedback to the user.

The above work when it is a “topic” they are creating. What we now need is exactly the same code, but for “replies”. In addition though, this warning needs to be placed just above the empty editor and just after the previous reply.

It is this code that is lacking for replies. So IMHO your comments don’t apply here. It is not about redirection or anything. It is about consistency with informing the user just like it does for a new topic.

I hope this helps you in resolving this issue and thank you so much for your time in looking into this.

The above begins on line 3029:

/**
 * Displays topic notices
 *
 * @since 2.0.0 bbPress (r2744)
 */
function bbp_topic_notices() {

[Chuckie]

If I create a topic, not a reply, and it goes to moderation, I am given a message at the top of the screen saying it has gone for moderation.

It should do exactly the same for a reply and zoom to the top of the topic to show the same message.

It should be the same behaviour. Except this time it is saying the reply has gone to moderation.

They are not redirected anywhere.

I had sent you screen shots about this and my posts in your own forum vanished. They must be in your own pending list.

See?

[Chuckie]

By the way, your forum shows differently. At all times it is showing a list of actual topics and not a list of forums inside a category and pulling out the most recent topic info per forum. So your context is different. Please go to my forum and create an account and a test message and / or a reply in one of the forums and you will see.

Andrew

[Chuckie]

As previously mentioned. At root level all freshness are wrong when topics are created and replies made:

Category 1
   Forum
   Forum
   Forum

Category 2
   Forum
   Forum
   Forum

Category 3
   Forum
   Forum
   Forum

Similarly, if I drill down a level:

Category 3
   Forum
   Forum
   Forum

This is still wrong. Freshness not showing the most recemt topic / reply info right. Unless I run the tool to rebuild freshness.

If I drill down a level:

Forum
   Topic
   Topic
   Topic

This always showed it correctly with the most recent freshness for the topic / reply in each forum.

I don’t think I can provide more info.

Andrew

[Chuckie]

I put my answer with images and the whole response is now missing. I assume it has gone to a moderation queue and not notified me on screen?

The above is wrong. I have now run the freshness tool and it has fixed it. But it keeps happening.

My forums are here.

[Chuckie]

Not really, but I’m just using a standard WP theme and it was working in 2.5, so 2.6 shouldn’t really have changed how it looks.

Fair point!

[Chuckie]

Not sure what you mean. I have:

Category
Forum
Forum
Forum

Category
Forum
Forum

Etc.

I have no sub categories.

Andrew

[Chuckie]

Thanks for your reply John. At the moment I do know enough about the mechanics of core WordPress functionality. Pity there is not a “php for dummies for WordPress” :).

Andrew

[Chuckie]

Thanks for looking into it John!

Andrew

[Chuckie]

I have looked at it more and it does actually tell you the “topic” is in moderation:

https://www.dropbox.com/s/3poekjgqibpnuv2/Moderation.jpg?dl=0

But if you make a “reply” and have two images in it you do not get the moderation warning.

So the mechanics must be there for showing the moderation feedback for replies as well as topics. Correct?

And as mentioned, I would be grateful if I could allow two or 3 images before moderation kicks in. It would be great.

Thanks ever so much for your hard work. Hope the above information helps.

Andrew

[Chuckie]

Well, I wish I could support php development but I don’t know enough about the project.

It stands to reason that a user needs to be provided feedback if their post has gone to moderation else they will wonder.

I had a user trying to put two or three images. It just didn’t work for him. I found them in pending list. So user feedback would be high on the list if not too hard. Ideally.

With thresholds for when items are marked as pending etc. Icing on the cake?

Doable?