[@robin-w Moderator 2 years, 5 months ago]

I’m just a guy sat in his kitchen trying to help others, I am not paid to do this.

It is entirely relevant in that they may well be a reason why trashed posts are added, without knowing when and why the function is called and how it is used, it is impossible to say that the code is wrong.

I agree that a filter before that or variable passed would be helpful, but bbpress is not being actively worked on at the moment so it is unlikely that this would get updated.

If you want to flag this, raise a ticket on https://bbpress.trac.wordpress.org/

You might want to use bbp_get_public_child_ids or use the filter at the end of the function to as you say ‘override’ the setting, or if you are using this function directly, then simply create your own version of it.