Milan Dinić (@dimadin)

Forum Replies Created

Viewing 25 replies - 1 through 25 (of 31 total)

  • Milan Dinić
    Participant

    @dimadin

    @jjj

    I didn’t understand from your reply do you want to add hooks that’ll purge cache made by caching plugins inside a core?

    Problem with page cache and bbPress (outside relative times) is that when something new is posted, parent post type(s) isn’t cleared (for example, when you post a reply, topic’s and forum’s pages aren’t refreshed until cache expires).


    Milan Dinić
    Participant

    @dimadin

    Since this topic tops Google SERP, just to note that for bbPress 2.0 (ie. bbPress as a WordPress plugin), there is a plugin bbPress Digest that does something similar as requested in first post.

    We’re going to be using it on a few community sites soon

    What community sites? Are wp.org support forums among them?


    Milan Dinić
    Participant

    @dimadin

    Milan, BBXF is a nice idea but, like BackPress, it’s a bit of a boil-the-ocean approach. From our point of view rather than getting every system in the world to adopt this new format, it’s better to just target importers for specific platforms as the market demands it, which has worked well on the WP side.

    Every system in the world doesn’t have to adopt BBXF. Since importers will already exist, why not make importers which will create BBXF if we already have some code and “standard”?


    Milan Dinić
    Participant

    @dimadin

    Non-plugin bbPress development is going to continue until we have a perfect importer so people will be able to bring their content out of the legacy codebase.

    So, will BBXF finally have some use?


    Milan Dinić
    Participant

    @dimadin

    There’s an official bbPress fork?

    Well, bbPress as a plugin is official bbPress fork. ;)


    Milan Dinić
    Participant

    @dimadin

    I just got the message about having the upgrade the database (due to subscribe to topic being added and a database change.)

    It seems that Matt listened to my request. Thank you, Matt!

    When editing a reply, the “Notify me of followup posts via e-mail” text appears twice (once below the “Allowed markup” and once above.)

    I think this is related to theme, I didn’t happen on my installation with Kakumei.

    Also, followup is probably a lot like the work “alot”. Should be “follow up” I think. The whole sentence might need to be reworded. They’re not posts, they’re replies, right?

    I made a patch that introduced this sentence and I copied it from popular WordPress plugin Subscribe to Comments. That of course doesn’t mean that it can’t be changed to any better one.

    I think “Topic” should probably not be capitalized in the sidebar link. Just a suggestion.

    This is how Matt made it when he introduced this feature in December (and how it was displayed here before update to 2.0), I didn’t change it in my patches.


    Milan Dinić
    Participant

    @dimadin

    we took 2 feautres which worked brialliantly as plugins and added them to the core; without any real need for that to happen.

    Subscribe to Topic wasn’t working without edits after 1.0 was released and _ck_ first announced that she won’t update any of her plugin until end of 2009 and later completely got out of bbPress world so we already needed a new plugin.


    Milan Dinić
    Participant

    @dimadin

    There are some improvements that are made to this feature that will solve some opinions expressed here. Read my detailed post for more information.


    Milan Dinić
    Participant

    @dimadin

    chrishajer just committed patches that improve subscription feature. Now we have a lot of new features:

    • option to disable/enable subscription in Options>Discussion
    • function for changing subscription status for user on topic (which means it could be used in plugins/themes
    • function for retrieving subscription status of user for topic
    • checkbox below post form for change of subscription status
    • links for subscription are now added to topicmeta action so on most if not all themes it will be shown without need for theme edit
    • a lot of filters/actions so you can remove features, change text etc
    • everything is well documented

    What this means is that now users don’t need to receive emails for every post since there are hooks in function that sends emails. Developers could make new features like sending digest email, one notification until user visits topic, page with list of subscribed topics for user. option to auto subscribe user to particular forum/tag (useful for plugin developers etc) and other.

    What you can also expect is that today or tomorrow you’ll again have option to subscribe to topics on this forum.

    Thanks to Gautam for a lot of improvements to my patch(es) and to Chris who committed final one.


    Milan Dinić
    Participant

    @dimadin

    If anyone reads this, link to download page from blog is broken.


    Milan Dinić
    Participant

    @dimadin

    As I said, I installed package from https://bbpress.org/download/. I forgot to mention this: I thought that maybe packages are automatically rebuilt after x hours and that in every rebuild newest version of BackPress is included since I don’t know how to explain this situation differently.


    Milan Dinić
    Participant

    @dimadin

    To repeat unfixed issues from my previous post here:

    • in login form in header, username and password are not deleted when you click on it, so you need to manually delete them (this is when you are logged put, of course)
    • better aligning on post form on plugin’s pages
    • more margin between columns on user’s favorites page
    • no subscribe to topic link (I’m now wondering could be this solved by using action topicmeta instead of hardcoding in theme since this won’t work in any theme by default)

    Ideas:

    • gravatars could be added to posts on plugin’s page too
    • RSS icons on links to RSS feeds


    Milan Dinić
    Participant

    @dimadin

    Anyone know how to change the plugin to utilize 3rd party smtp?

    Try this plugin.

    What is the ‘trunk version’ of bbpress?

    That is development version of bbPress, ie. one that will be released in future.


    Milan Dinić
    Participant

    @dimadin

    If you download that zip file, BackPress is missing.


    Milan Dinić
    Participant

    @dimadin

    Noel, here are problems that I think are important to fix:

    • no download link for plugins, version etc (major)
    • in login form in header, username and password are not deleted when you click on it, so you need to manually delete them
    • no subscribe to topic link (I’m now wondering could be this solved by using action topicmeta instead of hardcoding in theme since this won’t work in any theme by default)
    • better aligning on post form on plugin’s pages
    • better pagination on profile pages on forum
    • more margin between columns on user’s favorites page

    Also, gravatars could be added to posts on plugin’s page too.


    Milan Dinić
    Participant

    @dimadin

    There is plugin Unread Posts.


    Milan Dinić
    Participant

    @dimadin

    She said that about plugin Private Messaging but there is now popular plugin bbPM.

    In reply to: languages

    Milan Dinić
    Participant

    @dimadin

    You also need to edit file bb-config.php. Replace line define(‘BB_LANG’, ”); with define(‘BB_LANG’, ‘code’); where code is code of your langiage. eg. sr_RS.


    Milan Dinić
    Participant

    @dimadin

    zaerl, you helped me find a problem. I used filters above on 1.0.2 version where they don’t exist so it couldn’t work. It’s because on computer I have a trunk version where this is implemented.

    So on trunk version my code works as intended. Thank you both zaerl and ashfame.

    (btw, bb_send_pass filter doesn’t exists in 1.0.2 too, there is just a function with that name)


    Milan Dinić
    Participant

    @dimadin

    I have found solution for problem. Since I based form on Subscribe to Topics, I mistakenly used it’s arguments. So working function should be:

    function bb_checkbox_subscription_update($post_id) {

    global $bbdb, $bb_current_user, $bb_post, $topic, $wp_taxonomy_object;

    $bb_post=bb_get_post($post_id);

    if (!empty($_REQUEST)) {

    $checkbox_status = $_REQUEST;

    if ( ‘add’ == $checkbox_status ) {

    $tt_ids = $wp_taxonomy_object->set_object_terms( $bb_current_user->ID, ‘topic-‘ . $bb_post->topic_id, ‘bb_subscribe’, array( ‘append’ => true, ‘user_id’ => $bb_current_user->ID ) );

    } elseif ( ‘remove’ == $checkbox_status ) {

    // I hate this with the passion of a thousand suns

    $term_id = $bbdb->get_var( “SELECT term_id FROM $bbdb->terms WHERE slug = ‘topic-$bb_post->topic_id'” );

    $term_taxonomy_id = $bbdb->get_var( “SELECT term_taxonomy_id FROM $bbdb->term_taxonomy WHERE term_id = $term_id AND taxonomy = ‘bb_subscribe'” );

    $bbdb->query( “DELETE FROM $bbdb->term_relationships WHERE object_id = $bb_current_user->ID AND term_taxonomy_id = $term_taxonomy_id” );

    $bbdb->query( “DELETE FROM $bbdb->term_taxonomy WHERE term_id = $term_id AND taxonomy = ‘bb_subscribe'” );

    }

    }

    }

    Also, I made a code for improvements I suggested in first post. You can see it here. Also check this ticket.


    Milan Dinić
    Participant

    @dimadin

    @zaerl Thank you, but it doesn’t work. I also don’t see that filter bb_send_pass exists.


    Milan Dinić
    Participant

    @dimadin

    function bb_custom_pass_message ($message) {

    $message .= ‘My message.’;

    return $message;

    }

    add_filter( ‘bb_send_pass_message’, ‘bb_custom_pass_message’ );

    Another thing to consider is to find converter that converts from Wotlab to some other software like phpBB and then use existing converters for bbPress. This is how I converted on SMF forum.

    I think I have found a bug. From all three topics I’m subscribed to, this night I got four e-mails with spam posts from snj19 and yajia. I doubt that those post ever appeared on topic and they’re probably caught by Akismet, but they still were sent to e-mail subscribers.

    What is interesting is that there wasn’t title of topic in title of e-mail, as it was in other messages I got from here.

Viewing 25 replies - 1 through 25 (of 31 total)