found a slot whilst waiting for a client to respond !
@randrcomputers sinvce my code only runs on new topics – would be worth running a test with it enabled and disabled, and see if it makes a difference – if it does then come back.
found and fixed.
I’ve put the fix in my style pack plugin version 4.5.0
bbp style pack
once activated go to
dashboard>settings>bbp style pack>bug fixes
or put this in your child theme’s function file – or use
Code Snippets
add_filter ('bbp_get_topic_merge_link', 'rew_get_topic_merge_link' , 10 , 3) ;
add_filter ('bbp_is_topic_merge' , 'rew_is_topic_merge' ) ;
function rew_get_topic_merge_link( $args = array() ) {
// Parse arguments against default values
$r = bbp_parse_args( $args, array(
'id' => 0,
'link_before' => '',
'link_after' => '',
'merge_text' => esc_html__( 'Merge', 'bbpress' ),
), 'get_topic_merge_link' );
// Get topic
$topic = bbp_get_topic( $r['id'] );
// Bail if no topic or current user cannot moderate
if ( empty( $topic ) || ! current_user_can( 'moderate', $topic->ID ) ) {
return;
}
$uri = add_query_arg( array( 'action' => 'bbp-merge-topic' ), bbp_get_topic_edit_url( $topic->ID ) );
$retval = $r['link_before'] . '<a href="' . esc_url( $uri ) . '" class="bbp-topic-merge-link">' . $r['merge_text'] . '</a>' . $r['link_after'];
// Filter & return
return apply_filters( 'rew_get_topic_merge_link', $retval, $r, $args );
}
function rew_is_topic_merge() {
// Assume false
$retval = false;
// Check topic edit and GET params
if ( bbp_is_topic_edit() && ! empty( $_GET['action'] ) && ( 'bbp-merge-topic' === $_GET['action'] ) ) {
return true;
}
// Filter & return
return (bool) apply_filters( 'rew_is_topic_merge', $retval );
}
no problem in naming – there are thousands of plugins, and there is always the risk that 2 will use similar name and collide.
I’ll take a look, but maybe a day or 2
that code only runs when a new topic is posted, and should not be resource heavy.
Is it in your functions file or code snippets or elsewhere?
so in
dashboard>setting>forums I presume you have
Allow users to mark topics as favourites
set ?
it is theme related – all I can suggest is adding this in the custom css area of your theme
.`forum-archive .site-content-header {
display : none !important;
}`
ok, would you be happy for me to take a look at your site? if so, can you contact me via
Contact me
hmm – do you have sub forums?
how many forums, topics and replies roughly does you forum have ?
presume you have tried
dashboard>tools>forums>repair forums?
and does this work, even if for a shorttime ?
ok in menus, do not have a link, but have the page, that should help
you set up a page called say register_page and put this code into the content
[bbp-register]
so is this a new problem, has it always been the case, or a new site?
add_action ('bbp_theme_before_topic_form_notices' ,'rew_show_notice' ) ;
function rew_show_notice () {
if (!is_user_logged_in()) {
echo '<div class="rew-notice">Only registered users are allowed to upload attachments'</div>' ;
}
}
play with the width settings in the above code
width: calc(100% - 85px);
and
width: 84px;
dashboard>appearance>widgets>tag cloud and select topic tags
add_action ('bbp_theme_before_topic_form_notices' ,'rew_show_notice' ) ;
function rew_show_notice () {
echo '<div class="rew-notice">Only registered users are allowed to upload attachments'</div>' ;
}
can you post a link to an example and say EXACTLY where you want this
#bbp-search-form input[type="text"] {
font-size: 15px;
background: #fff;
border: 1px solid #bacad6;
margin-right: -4px;
border-right: 0;
border-top-left-radius: 5px;
border-bottom-left-radius: 5px;
border-top-right-radius: 0px;
border-bottom-right-radius: 0px;
width: calc(100% - 85px);
}
#bbp-search-form input[type="submit"] {
font-size: 15px;
border-top-right-radius: 5px;
border-bottom-right-radius: 5px;
border-top-left-radius: 0px;
border-bottom-left-radius: 0px;
width: 84px;
}
great – not sure why it didn’t work in code snippets (in essence it’s the same code as you’ve just enabled in style pack), but that will help me – glad you are fixed !!
you guessed right, we might need to do that.
This was found to happen with Theme my login plugin, which registered a public query which both use. My bug fix should have corrected that, even if another plugin is doing it.
But yes, we need to find which plugin is doing that.
however just before we do, can you take out the code above from code snippets
then in
dashboard>settings>bbp style pack>bug fixes, can you tick “Fix ‘A variable Mismatch has been detected’ ” save and try again.
then come back
