Jerry's Replies · bbPress.org

Forum Replies Created

Viewing 25 replies - 1 through 25 (of 30 total)

1 2 →

In reply to: showing topics from separate sites – need formatting help

@jerrysc

Participant

10 years, 4 months ago

Hi Robin. Sorry for the delayed response. It worked! Thanks for the simple fix. Now we know that shortcodes can take two inputs. If you need any of my code for use in a plugin, let me know. Though I have done things that are unique to my website, so they may not be as useful.

We can close this thread now.

In reply to: showing topics from separate sites – need formatting help

@jerrysc

Participant

10 years, 5 months ago

Hi Robin. Finally getting around to posting the error I see when trying to use two input parameters for a shortcode:
Warning: Illegal string offset 'id2' in /mysite/wp-content/plugins/recent-books-discussed/recent-books-discussed.php on line 33

I should probably start a different thread in the forums on this?

In reply to: showing topics from separate sites – need formatting help

@jerrysc

Participant

10 years, 5 months ago

Hi Robin. I’m on my way to the UK to support the Farnborough airshow, so I can’t access my home computer to replicate the error for another week. What I can tell you is; when I removed the switch_to_blog id input parameter and instead assigned a variable $cat to ‘post_parent’, and set $cat = $attr[‘id’];, I received no errors. I hard-coded to the blog site, then I can adjust the id to equal the forum id. So my feeling is that shortcodes cannot accept two inputs? If I’m wrong about that, then I will re-address this upon my return to the states.

In reply to: showing topics from separate sites – need formatting help

@jerrysc

Participant

10 years, 5 months ago

I have updated the code again, and I have a question to improve it a little. First the update; I had more trouble with formatting when I wanted to bring in topics from different sites. What I finally learned was to create a new id class and use it in my child theme style.css. Here is the updated code:

add_shortcode( 'recent-bbpress-topics', 'recent_bbpress_topics' );

// Add Recent Topics to BBPress from separate site within WP Multisite
function recent_bbpress_topics($attr) {
	//Switch to the blog where the bbpress topics are located
  switch_to_blog($attr['id']);

  //this, along with $response variable below, allows for display within content - without these, shortcode will display topics at top of content
  ob_start();
  if ( bbp_has_topics( array( 'author' => 0, 'show_stickies' => false, 'order' => 'DESC', 'post_parent' => 'any', 'posts_per_page' => 8 ) ) ) {
    //id class to be named "#recent-titles li.bbp-topic-title" and placed in style.css in the child theme ?>  
    <ul id="recent-titles">
      <?php while ( bbp_topics() ) : bbp_the_topic(); ?>
			<?php bbp_get_template_part( 'loop', 'single-topic' ); ?>
		  <?php endwhile; ?>
      <?php //bbp_get_template_part( 'loop', 'topics' ); ?>
    </ul>
    <?php //restore the current blog to maintain formatting 
    restore_current_blog();
    }
    //this, along with ob_start(); above, allows for display within content, instead of at the top of the content/page
    $response = ob_get_contents();
      ob_end_clean();
      return $response;
  }

And here is what I added to style.css:

/*Changes made to accommodate formatting for plugin recent-bbpress-changes*/
#recent-titles li.bbp-topic-title {
	float: left;
	text-align: left;
	width: 12%;
  overflow: hidden;
}

Notice how I declared the class id in the php code. One additional note; I have made several changes to my bbpress topics before I ever implemented this plugin. Perhaps other users will not require the css changes that I had to implement, post plugin activation.

Now for my question: Is it possible to have two input parameters to a shortcode? For this plugin, I would like to be able to change the input to “post_parent” as well as “switch_to_blog($attr[‘id’]);”. I’ve already tried to do this, but have failed. Here is what I tried:

function recent_bbpress_topics($attr,$attr2) {
	//Switch to the blog where the bbpress topics are located
  switch_to_blog($attr['id']);

  //this, along with $response variable below, allows for display within content - without these, shortcode will display topics at top of content
  ob_start();
  if ( bbp_has_topics( array( 'author' => 0, 'show_stickies' => false, 'order' => 'DESC', 'post_parent' => $attr2['id2'], 'posts_per_page' => 8 ) ) )

I end up getting an illegal string swap error. Anyone got any ideas here?

In reply to: showing topics from separate sites – need formatting help

@jerrysc

Participant

10 years, 5 months ago

Hi Robin. I made another improvement and added some comments. I noticed that, no matter where I inserted the shortcode, the topics displayed at the top of the content. After some searching I learned why – functions need to return a string. So I found an easy wordpress solution. I also simplified the shortcode, and removed the add_action line at the bottom as it was not doing anything. Here is the updated code:

add_shortcode( 'recent-bbpress-topics', 'recent_bbpress_topics' );

// Add Recent Topics to BBPress from separate site within WP Multisite
function recent_bbpress_topics($attr) {
    //Switch to the blog where the bbpress topics are located
    switch_to_blog($attr['id']);
    //this, along with $response variable below, allows for display within content - without these, shortcode will display topics at top of content
    ob_start();
  if ( bbp_has_topics( array( 'author' => 0, 'show_stickies' => false, 'order' => 'DESC', 'post_parent' => 'any', 'posts_per_page' => 9 ) ) ) { ?> 
      <?php bbp_get_template_part( 'bbpress/loop', 'topics' );
      //restore the current blog to maintain formatting
      restore_current_blog();
      }
      //this, along with ob_start(); above, allows for display within content, instead of at the top of the content/page
      $response = ob_get_contents();
        ob_end_clean();
        return $response;
}

In reply to: showing topics from separate sites – need formatting help

@jerrysc

Participant

10 years, 5 months ago

All css changes are within my child theme. For my child-theme’s style.css, I added this at the very bottom:

/*Changes made to accommodate plugin recent-bbpress-changes*/
#content ul {
padding: 0;
margin-left: 0;
margin-right: 0;
list-style: none;
}

For my bbpress.css in my child-theme, I added this around line 158 or so:

li.bbp-topic-title {
	float: left;
	text-align: left;
	width: 20%;

One note on bbpress.css. The original bbpress.css had some combined lines that I separated. For example, I think that li.bbp-topic-title was combined with li.bbp-forum-info, as in the following manner:

li.bbp-forum-info,
li.bbp-topic-title {
	float: left;
	text-align: left;
	width: 20%;

But I could be wrong. Doesn’t matter. Separating them appears to be just fine.

In reply to: showing topics from separate sites – need formatting help

@jerrysc

Participant

10 years, 5 months ago

Got it solved! First, sorry for all the responses. I got lazy in posting the above instead of searching for the solution in the wordpress codex first. Turns out there is a function to return to the current blog, which I inserted within the “if” statement. Specifically, it is “restore_current_blog();”. Here is the working code:

<?php
/* 
		Plugin Name: Recent bbpress Topics
		Plugin URI: http://whosgotbooks.com/wp-content/plugins
		Description: A plugin to display recent bbpress topics across the network
		Version: 1.0.0
		Author: Jerry Caldwell
		Author URI: http://whosgotbooks.com
		License: Open Source
*/ 
/*
Here is the shortcode required [recent-bbpress-topic]
*/
function recent_bbpress_topics_shortcode() {                  
  recent_bbpress_topics(); }
  add_shortcode( 'recent-bbpress-topics', 'recent_bbpress_topics_shortcode' );

//Add Recent Topics to BBPress
function recent_bbpress_topics() {
		switch_to_blog(9);
  if ( bbp_has_topics( array( 'author' => 0, 'show_stickies' => false, 'order' => 'DESC', 'post_parent' => 'any', 'posts_per_page' => 7 ) ) ) { 
      bbp_get_template_part( 'bbpress/loop', 'topics' );
      restore_current_blog();
      }
// Hook into action
add_action('bbp_template_after_forums_loop','recent_bbpress_topics');
} ?>

For anyone who wants to use this, a few more points. One, don’t forget the formatting for style.css. Two, I changed that formatting within a child theme. Three, I can’t guarantee you will have the same results with your formatting as I have made many other formatting changes the past few months for my site. Lastly, I did not “network activate” my plugin. I only activated it on the main site.
As I get time I will add comments and try to increase the functionality of this plugin. Right now it is very basic. Maybe I’ll get good enough to publish it?

In reply to: showing topics from separate sites – need formatting help

@jerrysc

Participant

10 years, 5 months ago

Update on this. It turns out my code was insufficient. If have fixed it, sort of, which has led to another problem. First, here is the updated code:

<?php
/* 
		Plugin Name: Recent bbpress Topics
		Plugin URI: http://whosgotbooks.com/wp-content/plugins
		Description: A plugin to display recent bbpress topics across the network
		Version: 1.0.0
		Author: Jerry Caldwell
		Author URI: http://whosgotbooks.com
		License: Open Source
*/ 
function recent_bbpress_topics_shortcode() {                  
  recent_bbpress_topics(); }
  add_shortcode( 'recent-bbpress-topics', 'recent_bbpress_topics_shortcode' );

//Add Recent Topics to BBPress
function recent_bbpress_topics() {
	switch_to_blog(9);
  if ( bbp_has_topics( array( 'author' => 0, 'show_stickies' => false, 'order' => 'DESC', 'post_parent' => 'any', 'posts_per_page' => 7 ) ) ) { 
      bbp_get_template_part( 'bbpress/loop', 'topics' );
      }
// Hook into action
add_action('bbp_template_after_forums_loop','recent_bbpress_topics');
} ?>

Using the line “switch_to_blog(9);” works great to get the topics from site 9 to the main site. But now my problem is; it brings some unwanted behavior. The main content looks great, but the sidebars change to the format of site 9. Perhaps this has become a wordpress issue and not a bbpress issue? Perhaps I need to use code in addition to “switch_to_blog(9);” that prevents the unwanted behavior? If I need to change this to a wordpress thread, please let me know and I will. Otherwise, if you can provide a solution, that would be great.

In reply to: showing topics from separate sites – need formatting help

@jerrysc

Participant

10 years, 5 months ago

Thanks Robin! Thanks Peter! After some trouble-shooting, the answer is as follows:

#content ul {
padding: 0;
margin-left: 0;
list-style: none;
}

For some reason, if I use “ul” twice after “#content”, it doesn’t quite work.
I was using firebug, and had identified line 118 in style.css, but just didn’t make the exact connection on how to change it. I used firebug again this morning, and learned how to use it better, so thanks for leading me to a great lesson!
Robin; if you want to make this into a plugin where the user gets some options on the back-end, I will be happy to help with the grunt work and you can post it and get the credit. Just let me know, and give me some direction.
Thanks again…

PS For anyone who uses this code, I made the css changes in my style.css within my Child Theme, not the main style.css.

In reply to: modifying functions in includes directory, use bbpress-functions.php?

@jerrysc

Participant

bbPress.org

Jerry (@jerrysc)

Forum Replies Created