My final solution was to make bbPress ‘dumb’ when it comes to logged out users. I.e., it could either be clever and say “there are topics, but you’re not allowed to see them until you login” or it could just say “there are no topics”.
Thanks for the code! I have it working but I dont follow what you mean with the quoted login.
Is this a shortcode setting, or are you changing the default message of “Oh bother! No forums were found here!”.