Skip to:
Content
Pages
Categories
Search
Top
Bottom

Which widget is this

Viewing 12 replies - 1 through 12 (of 12 total)

  • Robin W
    Moderator

    @robin-w

    none in bbpress, but I added the capability in style pack

    bbp style pack

    once activated you’ll see it in the widgets as

    (style pack) Single topic info


    SirLouen
    Participant

    @sirlouen

    Thanks @robin-w

    Just a little tweak, with the bsp-st-title-container class in includes/widgets.php line it would be great that you include the widget class to keep it WP compliant.


    SirLouen
    Participant

    @sirlouen

    Also, within bsp-sf-title-container (line 652)


    Robin W
    Moderator

    @robin-w

    fancy giving me the corrected lines? 🙂


    SirLouen
    Participant

    @sirlouen

    484 and 652

    echo '<div class="widget bsp-st-title-container">';

    echo '<div class="widget bsp-sf-title-container">';


    Robin W
    Moderator

    @robin-w

    just released 4.4.1 which has those changes in


    SirLouen
    Participant

    @sirlouen

    Another tweak (both for st and sf)
    You could move from 556 to 562

    over the 555:
    echo '</ul>' ; //end of '<ul class="bsp-st-info-list">'; ?>

    To have all “li” in the same “ul”

    (Same in line 725)

    Remember to close some of the ?> lingering afterwards 🙂


    Robin W
    Moderator

    @robin-w

    sorry I’m really busy at the moment – it would really help me if you could paste revised code 🙂


    SirLouen
    Participant

    @sirlouen

    Also, I’m not sure if this is intended but similarly to the other elements this last two don’t have their “show-icon” class with

    font-family: 'dashicons';
    content: '\f155';

    and

    font-family: 'dashicons';
    content: '\f147';

    But could be included with this CSS code (I’ve included in my custom anyway but just to get the same format)

    .sidebar .bsp-st-info-list li.topic-favorite:before {
    	font-family: 'dashicons';
        content: '\f155';
    }
    .sidebar .bsp-st-info-list li.topic-subscribe:before, .sidebar .bsp-sf-info-list li.forum-subscribe:before {
        font-family: 'dashicons';
    	content: '\f147';
    }

    About the other topic here the two snippets (I’m copying a little in the top and in the bottom:

    Around 555

    <?php if ( !empty( $time_since  ) ) : ?>
                            <li class="topic-freshness-time <?php echo $show_iconla ; ?> ">
                            <?php
                                    echo $settings['last_activity'];
                                    echo $time_since ;
                            ?></li>
                    <?php endif; ?>
                    <?php if ( is_user_logged_in() ) : ?>
                            <?php $_topic_id = bbp_is_reply_edit() ? bbp_get_reply_topic_id() : $topic_id; ?>
                            
                            <li class="topic-subscribe"><?php bbp_topic_subscription_link( array( 'before' => '', 'topic_id' => $_topic_id ) ); ?></li>
                            <li class="topic-favorite"><?php bbp_topic_favorite_link( array( 'topic_id' => $_topic_id ) ); ?></li>
                            
                    <?php endif; ?>
                    <?php
                    echo '</ul>' ; // end of '<ul class="bsp-st-info-list">;
                    echo '</div>'; // end of '<div class="bsp-st-title-container">';
            }

    Around 725

    <li class="topic-freshness-time <?php echo $show_iconla ; ?> ">
                            <?php
                                    echo $settings['last_activity'];
                                    echo $time_since ;
                            ?></li>
    
                    <?php endif; ?>
                    <?php if ( is_user_logged_in() ) : ?>
                            <li class="forum-subscribe">
                                    <?php 
                                            bbp_forum_subscription_link( array( 'forum_id' => $forum_id ) ); 
                            ?></li>
                    <?php endif; ?>
                    <?php 
                            echo '</ul>' ;
                            echo '</div>' ; // end of <div class="bsp-st-title-container">
            }

    Robin W
    Moderator

    @robin-w

    @sirlouen – thanks, I’ve incorporated all those changes in 4.4.2

    Let me know if I missed anything

    and thanks so much for helping me improve my plugin – as a one man developer/tester it’s hard to spot where code can be improved !


    SirLouen
    Participant

    @sirlouen

    I have upgraded and everything seems fine so far except one very little mistake (don’t need to upgrade for this)

    show-iconfa is showing \f155
    and
    show-iconsu is showing \f147

    And is the other way around


    Robin W
    Moderator

    @robin-w

    great thanks – I’ve changed it and it will go on then next release

    thanks again 🙂

Viewing 12 replies - 1 through 12 (of 12 total)
  • You must be logged in to reply to this topic.
Skip to toolbar