[Amin]

Hi there,

WP: 4.8.2
BBP: 2.5.14

After digging into lots of pages, I finally found an old topic here that describes the same problem I have. As it’s an ancient topic, I started a new one.

For topics with more than 1000 replies, when posting new replies, bbpress does not add the page number to the reply permalink. I did as the user Matrixd said here(of course for new versions of bbpress with different paths):

Hello again, finally after John’s helpful tip, I was able to fix the issue. I found where BBpress does the number formatting and disabled it. In wp-content/plugins/bbpress/bbp-includes/bbp-common-functions.php I changed this line:

function bbp_number_format( $number = 0, $decimals = false, $dec_point = '.', $thousands_sep = ',' ) {

to:

function bbp_number_format( $number = 0, $decimals = false, $dec_point = '.', $thousands_sep = '' ) {

This removes the comma from the thousands separator. Now all topics pages appear correctly. Thanks!

And the problem solved!
But this is a core hack, I want it as an additional function without touching core files.

[Amin]

I would appreciate it if any developer can help.

[Robin W]

you can simply filter this in your theme’s function file.

not tested but

add_filter( 'bbp_number_format', 'rew_number_format', 10 , 5) ;

function rew_number_format ($number_format, $number, $decimals, $dec_point, $thousands_sep) {
	$thousands_sep = '' ;
return apply_filters( 'rew_number_format', number_format( $number, $decimals, $dec_point, $thousands_sep ), $number, $decimals, $dec_point, $thousands_sep );
}

[Amin]

It woked. Thank you so much 🙂 🙂
I wish I knew you as well…

[Robin W]

great – glad you are fixed !!

[lambangdaihoc]

thank you so much

[Pascal Casier]

@aminima just for your information, in the upcoming v2.6 of bbPress this has been fixed.

[Amin]

Glad to hear that 🙂

[John James Jacoby]

I am pretty sure this is fixed in trunk for 2.6, but it’s a bug that’s come back a few different times, so I try to keep an eye out for it.

Sorry for the trouble!

[Editor Mike]

Hi,

I have this issue too.
However I have zero coding skills, where do I paste that fix in order to sort it?

Sorry for being clueless.

[Amin]

put it in your theme’s function.php file.
or if you have buddypress installed too, put it in bp-custom.php.

[Editor Mike]

Is that via the WP dashboard or via my server and into the file itself?

[Editor Mike]

Sorry, also… where abouts?

[Robin W]

probably easier to just add the plugin ‘code snippets’ into your site and put the code there.

That way you will not risk breaking your site

[Editor Mike]

Thanks, that looked handy, but just tried it and it does not seem to have sorted the issue.
Still will not go to the latest reply on topics over 1000.

Topic in question:

Crom's Anvil – 15mm Fantasy

When you click on the last updated by link it changes the URL in the browser but does not actually take you to it…

[Editor Mike]

I did a batch of forum repair actions and it fixed the issue.
You can now click on the last updated by and it takes you to that reply.
What I have noticed is that after running the repair tool the URL of the last reply includes the page number and topic number.
Before running the tool when it did not work, the URL just showed the reply number with no page number listed…

I will update if it breaks again.

[Editor Mike]

So, fixing the bbpress forum relationships fixed the problem.
However any new post once the repair forum tool is used negates that fix.
The last updated by no longer works and the URL has reverted to showing only the post number without the page number.

[Robin W]

can you post exactly what you put in the code snippets please

[Editor Mike]

add_filter( ‘bbp_number_format’, ‘rew_number_format’, 10 , 5) ;

function rew_number_format ($number_format, $number, $decimals, $dec_point, $thousands_sep) {
	$thousands_sep = '' ;
return apply_filters( 'rew_number_format', number_format( $number, $decimals, $dec_point, $thousands_sep ), $number, $decimals, $dec_point, $thousands_sep );
}

[Robin W]

that should work, I’m not sure how to help further

[Pascal Casier]

@editor-mike,

If it does not seem to work, you can also find the option in my bbp-toolkit plugin in the ‘Extras’ tab.

Let me know if that worked after you activated the plugin and the option.

[Robin W]

@casiepa – sorry forgot that was in your plugin !

@editor-mike – go with Pascal’s idea and see if that fixes !

[Pascal Casier]

@robin-w

It’s brand new, so you just couldn’t know 🙂

[Robin W]

@casiepa – I try to keep up with what’s there as I try not to duplicate, but yes I hadn’t forgotten, but forgot that I didn’t know 🙂

[Editor Mike]

Hi, thanks for that.
I hit the extras and the pagination bit, still no joy.

🙁

All topics are fine, just this one with over 1000 replies:

Crom's Anvil – 15mm Fantasy

[Editor Mike]

So, this problem has just appeared again.
Yesterday it was fine, now again when clicking the last updated by you get the topic number but not the page number…

Crom's Anvil – 15mm Fantasy

https://www.thewargameswebsite.com/forums/topic/abs-15mm-fantasy-thing/#post-107748″