bbPress.org

RSS feeds work here and on other sites, so I’m going to guess it’s deep integration or …

XML Parsing Error: undefined entity

Location: http://canadianrugby.ca/forums/rss/topic/canadian-players-overseas

Line Number 10, Column 38:		<description>Canadian Rugby Forums &raquo; Topic: Canadian Players Overseas</description>

^

Might that be related to https://bbpress.org/forums/topic/fix-to-rss-xml-parsing-error#post-8864

Member

@rohan_kapoor

Nope that didn’t help. I reloaded the rss2.php file to the default kakumei and then disabled deep integration as well. The client states that rss is very important to him. Does anyone have any ideas?

Member

@rohan_kapoor

Speaking of Broken RSS Feeds, the ones on this forum are broken as well.

chrishajer

Participant

@chrishajer

I have a 1.0.1 installation that works fine, but this 1.0.2 installation does not seem to work.

One difference I noticed in the 1.0.1 installation. When you click on a topic feed, the feed <description> looks like this:

$site_title Topic: $topic_title – the » is missing.

With the 1.0.2 feed, it looks like this:

$site_title » Topic: $topic_title

It’s the » that is creating problems in the feed, at least with Firefox and IE8.

Member

@rohan_kapoor

Neither the rss.php nor the theme specific rss2.php have either of those lines of code in them. Do you want to elaborate, please?

chrishajer

Participant

@chrishajer

Sorry, I was substituting pseudo-variable names in there: $site_title is the site title from the admin (“bbPress Support Forums” here) and the $topic_title is the topic title (this topic has “All RSS Feeds Broken?”). So, here, the RSS description is

bbPress Support Forums » Topic: All RSS Feeds Broken?

.......................^

and in a 1.0.1 installation it is

bbPress Support Forums Topic: All RSS Feeds Broken?

There is no raquo in the 1.0.1 installation, and the feed validator is complaining about that one character.

Member

@rohan_kapoor

Ah ok. So what would I change to fix this?

myballard

Participant

@myballard

Ditto here. It’s choking on the » character. No RSS feeds work, including here on BBPress’ own forum.

Fix please?

Ipstenu (Mika Epstein)

Moderator

@ipstenu

@chrishajer – That’s … weird. I have 1.0.2 on my sites and the rss works fine. And the errors here are very different than Rohan’s.

Member

@kirpiit

I do not know what happened in the last two weeks, but also my fresh 1.0.2 install throws an error when clicking on a “RSS feed for this topic”.


Errore interpretazione XML: la dichiarazione XML o testuale non è all'inizio di un'entità
Indirizzo: http://www.kirpi.it/r/rss/topic/test-di-lenti
Linea numero 2, colonna 1:<?xml version="1.0" encoding="UTF-8"?>
^

Any idea about it, please?

Does anybody know if the issue has been addressed, so that instead of spoiling my site in the effort to fix it, I’d better wait for the next release?

Member

@kirpiit

https://bbpress.org/forums/rss/topic/swedish-translation-completed-bbpress-10-rc-3

Yes, it seems that also here RSS do not work anymore…

Any idea about what is wrong?

bbhack

Member

@bbhack

https://trac.bbpress.org/changeset/2323

To fix this you will need to remove the raquo characters from your core rss.php file. Then your RSS feeds will work again.

It looks like this bug was introduced in changeset 2323

bbhack

Member

@bbhack

https://trac.bbpress.org/ticket/1181

There is also a patch here (see the attachements section of the ticket page below) –

But I haven’t tried the patch myself.

Member

@kirpiit

I saw https://trac.bbpress.org/attachment/ticket/1181/full-rss-filters.patch

Thank you bbhack.

How am I supposed to use that page, please?

Is it right to open all the files involved in my actual install, delete the lines in red and add those which are in green, manually?

Member

@kirpiit

> https://trac.bbpress.org/attachment/ticket/1181/full-rss-filters.patch

I don’t seem to be able and reproduce the new version of the files, also because the code in 1.0.2 seems to be slightly different from the one I’m supposed to edit, and I get easily lost (not being a coder myself).

I tried all my best, but still the feed throws an error and does not get created.

Are such files dowloadable from any source, please?

deadlyhifi

Participant

@tomdebruin

The fix in track wraps CDATA around the title and description, then the &raquo’s work fine and it all validates.

In your theme’s rss2.php replace with this:

<?php

header( 'Content-Type: text/xml; charset=UTF-8' );

echo '<' . '?xml version="1.0" encoding="UTF-8"?' . '>' . "n";

bb_generator( 'comment' );

?>

<rss version="2.0"

xmlns:content="http://purl.org/rss/1.0/modules/content/"

xmlns:dc="http://purl.org/dc/elements/1.1/"

xmlns:atom="http://www.w3.org/2005/Atom">

<channel>

<title><?php echo $title; ?></title>

<link><?php echo $link; ?></link>

<description><![CDATA[<?php echo $description; ?>]]></description>

<language><?php esc_html( bb_option('language') ); ?></language>

<pubDate><?php echo gmdate('D, d M Y H:i:s +0000'); ?></pubDate>

<?php bb_generator( 'rss2' ); ?>

<textInput>

<title><![CDATA[<?php _e('Search'); ?>]]></title>

<description><![CDATA[<?php _e('Search all topics from these forums.'); ?>]]></description>

<name>q</name>

<link><?php bb_uri('search.php'); ?></link>

</textInput>

<atom:link href="<?php echo $link_self; ?>" rel="self" type="application/rss+xml" />



<?php foreach ($posts as $bb_post) : ?>

<item>

<title><?php post_author(); ?> <?php _e('on')?> "<?php topic_title( $bb_post->topic_id ); ?>"</title>

<link><?php post_link(); ?></link>

<pubDate><?php bb_post_time('D, d M Y H:i:s +0000', array( 'localize' => false ) ); ?></pubDate>

<dc:creator><?php post_author(); ?></dc:creator>

<guid isPermaLink="false"><?php post_id(); ?>@<?php bb_uri(); ?></guid>

<description><?php post_text(); ?></description>

</item>

<?php endforeach; ?>



</channel>

</rss>

Member

@kawauso

With the final patch from track applied against 1.0.2 trunk you get:

bb-templates/kakumei/rss2.php

<?php

header( 'Content-Type: text/xml; charset=UTF-8' );

echo '<' . '?xml version="1.0" encoding="UTF-8"?' . '>' . "n";

bb_generator( 'comment' );

?>

<rss version="2.0"

xmlns:content="http://purl.org/rss/1.0/modules/content/"

xmlns:dc="http://purl.org/dc/elements/1.1/"

xmlns:atom="http://www.w3.org/2005/Atom">

<channel>

<title><?php echo $title; ?></title>

<link><?php echo $link; ?></link>

<description><?php echo $description; ?></description>

<language><?php esc_html( bb_option('language') ); ?></language>

<pubDate><?php echo gmdate('D, d M Y H:i:s +0000'); ?></pubDate>

<?php bb_generator( 'rss2' ); ?>

<textInput>

<title><![CDATA[<?php _e('Search'); ?>]]></title>

<description><![CDATA[<?php _e('Search all topics from these forums.'); ?>]]></description>

<name>q</name>

<link><?php bb_uri('search.php'); ?></link>

</textInput>

<atom:link href="<?php echo $link_self; ?>" rel="self" type="application/rss+xml" />



<?php foreach ($posts as $bb_post) : ?>

<item>

<title><?php post_author(); ?> <?php _e('on')?> "<?php topic_title( $bb_post->topic_id ); ?>"</title>

<link><?php post_link(); ?></link>

<pubDate><?php bb_post_time('D, d M Y H:i:s +0000', array( 'localize' => false ) ); ?></pubDate>

<dc:creator><?php post_author(); ?></dc:creator>

<guid isPermaLink="false"><?php post_id(); ?>@<?php bb_uri(); ?></guid>

<description><?php post_text(); ?></description>

</item>

<?php endforeach; ?>



</channel>

</rss>

bb-includes/defaults.bb-filters.php

<?php

/**

* Sets up the default filters and actions for most

* of the bbPress hooks.

*

* If you need to remove a default hook, this file will

* give you the priority for which to use to remove the

* hook.

*

* Not all of the default hooks are found in this files

*

* @package bbPress

*/



// Strip, trim, kses, special chars for string saves

$filters = array( 'pre_term_name', 'bb_pre_forum_name', 'pre_topic_title' );

foreach ( $filters as $filter ) {

add_filter( $filter, 'strip_tags' );

add_filter( $filter, 'trim' );

add_filter( $filter, 'bb_filter_kses' );

add_filter( $filter, 'esc_html', 30 );

}



// Kses only for textarea saves

$filters = array( 'pre_term_description', 'bb_pre_forum_desc' );

foreach ( $filters as $filter ) {

add_filter( $filter, 'bb_filter_kses' );

}



// Slugs

add_filter( 'pre_term_slug', 'bb_pre_term_slug' );



// DB truncations

add_filter( 'pre_topic_title', 'bb_trim_for_db_150', 9999 );

add_filter( 'bb_pre_forum_name', 'bb_trim_for_db_150', 9999 );

add_filter( 'pre_term_name', 'bb_trim_for_db_55', 9999 );



// Format Strings for Display

$filters = array( 'forum_name', 'topic_title', 'bb_title', 'bb_option_name' );

foreach ( $filters as $filter ) {

add_filter( $filter, 'esc_html' );

}



// Numbers

$filters = array( 'forum_topics', 'forum_posts', 'total_posts', 'total_users', 'total_topics' );

foreach ( $filters as $filter ) {

add_filter( $filter, 'bb_number_format_i18n' );

}



// Offset Times

$filters = array( 'topic_time', 'topic_start_time', 'bb_post_time' );

foreach ( $filters as $filter ) {

add_filter( $filter, 'bb_offset_time', 10, 2 );

}



add_filter('bb_topic_labels', 'bb_closed_label', 10);

add_filter('bb_topic_labels', 'bb_sticky_label', 20);



add_filter('pre_post', 'trim');

add_filter('pre_post', 'bb_encode_bad');

add_filter('pre_post', 'bb_code_trick');

add_filter('pre_post', 'force_balance_tags');

add_filter('pre_post', 'bb_filter_kses', 50);

add_filter('pre_post', 'bb_autop', 60);



add_filter('post_text', 'do_shortcode');



function bb_contextualise_search_post_text()

{

if ( bb_is_search() ) {

add_filter( 'get_post_text', 'bb_post_text_context' );

}

}

add_action( 'bb_init', 'bb_contextualise_search_post_text' );



add_filter('post_text', 'make_clickable');



add_filter('edit_text', 'bb_code_trick_reverse');

add_filter('edit_text', 'wp_specialchars');

add_filter('edit_text', 'trim', 15);



add_filter('pre_sanitize_with_dashes', 'bb_pre_sanitize_with_dashes_utf8', 10, 3 );



add_filter('get_user_link', 'bb_fix_link');



add_filter('sanitize_profile_info', 'esc_html');

add_filter('sanitize_profile_admin', 'esc_html');



add_filter( 'get_recent_user_replies_fields', 'bb_get_recent_user_replies_fields' );

add_filter( 'get_recent_user_replies_group_by', 'bb_get_recent_user_replies_group_by' );



add_filter('sort_tag_heat_map', 'bb_sort_tag_heat_map');



// URLS



if ( !bb_get_option( 'mod_rewrite' ) ) {

add_filter( 'bb_stylesheet_uri', 'esc_attr', 1, 9999 );

add_filter( 'forum_link', 'esc_attr', 1, 9999 );

add_filter( 'bb_forum_posts_rss_link', 'esc_attr', 1, 9999 );

add_filter( 'bb_forum_topics_rss_link', 'esc_attr', 1, 9999 );

add_filter( 'bb_tag_link', 'esc_attr', 1, 9999 );

add_filter( 'tag_rss_link', 'esc_attr', 1, 9999 );

add_filter( 'topic_link', 'esc_attr', 1, 9999 );

add_filter( 'topic_rss_link', 'esc_attr', 1, 9999 );

add_filter( 'post_link', 'esc_attr', 1, 9999 );

add_filter( 'post_anchor_link', 'esc_attr', 1, 9999 );

add_filter( 'user_profile_link', 'esc_attr', 1, 9999 );

add_filter( 'profile_tab_link', 'esc_attr', 1, 9999 );

add_filter( 'favorites_link', 'esc_attr', 1, 9999 );

add_filter( 'view_link', 'esc_attr', 1, 9999 );

}



// Feed Stuff



function bb_filter_feed_content()

{

if ( bb_is_feed() ) {

add_filter( 'bb_title_rss', 'strip_tags');

add_filter( 'bb_title_rss', 'ent2ncr', ;

add_filter( 'bb_title_rss', 'esc_html' );



add_filter( 'bb_description_rss', 'strip_tags');

add_filter( 'bb_description_rss', 'ent2ncr', 8 );

add_filter( 'bb_description_rss', 'esc_html' );



add_filter( 'post_author', 'ent2ncr', 8 );



add_filter( 'post_link', 'esc_html' );



add_filter( 'post_text', 'ent2ncr' );

add_filter( 'post_text', 'htmlspecialchars' ); // encode_bad should not be overruled by esc_html

}

}

add_action( 'bb_init', 'bb_filter_feed_content' );



add_filter( 'init_roles', 'bb_init_roles' );

add_filter( 'map_meta_cap', 'bb_map_meta_cap', 1, 4 );



// Actions



add_action( 'bb_head', 'bb_generator' );

add_action('bb_head', 'bb_template_scripts');

add_action('bb_head', 'wp_print_scripts');

add_action('bb_head', 'wp_print_styles');

add_action('bb_head', 'bb_rsd_link');

add_action('bb_head', 'bb_pingback_link');

if ( $bb_log->type === 'console' ) {

add_action('bb_head', array(&$bb_log, 'console_javascript'));

add_action('bb_admin_head', array(&$bb_log, 'console_javascript'));

}

add_action('bb_send_headers', 'bb_pingback_header');

add_action('bb_admin_print_scripts', 'wp_print_scripts');



add_action('bb_user_has_no_caps', 'bb_give_user_default_role');



add_action('do_pingbacks', array('BB_Pingbacks', 'send_all'), 10, 1);



add_action( 'bb_init', 'bb_register_default_views' );



add_action( 'set_current_user', 'bb_apply_wp_role_map_to_user' );



add_filter( 'bb_pre_get_option_gmt_offset', 'wp_timezone_override_offset' );



unset( $filters, $filter );

rss.php

<?php

require('./bb-load.php');



// Determine the type of feed and the id of the object

if ( isset($_GET['view']) || bb_get_path() == 'view' ) {



// View

$feed = 'view';

$feed_id = isset($_GET['view']) ? $_GET['view'] : bb_get_path(2);



} elseif ( isset($_GET['topic']) || bb_get_path() == 'topic' ) {



// Topic

$feed = 'topic';

$topic = get_topic(isset($_GET['topic']) ? $_GET['topic'] : bb_get_path(2));

$feed_id = $topic->topic_id;



} elseif ( isset($_GET['profile']) || bb_get_path() == 'profile' ) {



// Profile

$feed = 'profile';

$feed_id = isset($_GET['profile']) ? $_GET['profile'] : bb_get_path(2);



} elseif ( isset($_GET['tag']) || bb_get_path() == 'tags' ) {



if ( isset($_GET['topics']) || bb_get_path(3) == 'topics' ) {

// Tag recent topics

$feed = 'tag-topics';

} else {

// Tag recent posts

$feed = 'tag-posts';

}

$feed_id = isset($_GET['tag']) ? $_GET['tag'] : bb_get_path(2);



} elseif ( isset($_GET['forum']) || bb_get_path() == 'forum' ) {



if ( isset($_GET['topics']) || bb_get_path(3) == 'topics' ) {

// Forum recent topics

$feed = 'forum-topics';

} else {

// Forum recent posts

$feed = 'forum-posts';

}

$forum = bb_get_forum(isset($_GET['forum']) ? $_GET['forum'] : bb_get_path(2));

$feed_id = $forum->forum_id;



} elseif ( isset($_GET['topics']) || bb_get_path() == 'topics' ) {



// Recent topics

$feed = 'all-topics';



} else {



// Recent posts

$feed = 'all-posts';



}



// Initialise the override variable

$bb_db_override = false;

do_action( 'bb_rss.php_pre_db' );



if ( !$bb_db_override ) {



// Get the posts and the title for the given feed

switch ($feed) {

case 'view':

if ( !isset($bb_views[$feed_id]) )

die();

if ( !$bb_views[$feed_id]['feed'] )

die();

if ( !$topics_object = new BB_Query( 'topic', $bb_views[$feed_id]['query'], "bb_view_$feed_id" ) )

die();



$topics = $topics_object->results;

if ( !$topics || !is_array($topics) )

die();



$posts = array();

foreach ($topics as $topic) {

$posts[] = bb_get_first_post($topic->topic_id);

}



$title = sprintf( __( '%1$s » View: %2$s' ), bb_get_option( 'name' ), $bb_views[$feed_id]['title'] );

$link = get_view_link($feed_id);

$link_self = bb_get_view_rss_link($feed_id);

break;



case 'topic':

if ( !$topic = get_topic ( $feed_id ) )

die();

if ( !$posts = get_thread( $feed_id, 0, 1 ) )

die();

$title = sprintf( __( '%1$s » Topic: %2$s' ), bb_get_option( 'name' ), get_topic_title() );

$link = get_topic_link($feed_id);

$link_self = get_topic_rss_link($feed_id);

break;



case 'profile':

if ( bb_get_option( 'mod_rewrite' ) === 'slugs' ) {

$user = bb_get_user_by_nicename( $feed_id );

} else {

$user = bb_get_user( $feed_id );

}

if ( !$user ) {

die();

}

if ( !$posts = get_user_favorites( $user->ID ) ) {

die();

}

$title = sprintf( __( '%1$s » User Favorites: %2$s' ), bb_get_option( 'name' ), $user->user_nicename );

$link = bb_get_profile_link($feed_id);

$link_self = get_favorites_rss_link($feed_id);

break;



case 'tag-topics':

if ( !$tag = bb_get_tag( $feed_id ) )

die();

if ( !$topics = get_tagged_topics( array( 'tag_id' => $tag->tag_id, 'page' => 0 ) ) )

die();



$posts = array();

foreach ($topics as $topic) {

$posts[] = bb_get_first_post($topic->topic_id);

}



$title = sprintf( __( '%1$s » Tag: %2$s - Recent Topics' ), bb_get_option( 'name' ), bb_get_tag_name() );

$link = bb_get_tag_link($feed_id);

$link_self = bb_get_tag_topics_rss_link($feed_id);

break;



case 'tag-posts':

if ( !$tag = bb_get_tag( $feed_id ) )

die();

if ( !$posts = get_tagged_topic_posts( array( 'tag_id' => $tag->tag_id, 'page' => 0 ) ) )

die();

$title = sprintf( __( '%1$s » Tag: %2$s - Recent Posts' ), bb_get_option( 'name' ), bb_get_tag_name() );

$link = bb_get_tag_link($feed_id);

$link_self = bb_get_tag_posts_rss_link($feed_id);

break;



case 'forum-topics':

if ( !$topics = get_latest_topics( $feed_id ) )

die();



$posts = array();

foreach ($topics as $topic) {

$posts[] = bb_get_first_post($topic->topic_id);

}



$title = sprintf( __( '%1$s » Forum: %2$s - Recent Topics' ), bb_get_option( 'name' ), get_forum_name( $feed_id ) );

$link = get_forum_link($feed_id);

$link_self = bb_get_forum_topics_rss_link($feed_id);

break;



case 'forum-posts':

if ( !$posts = bb_get_latest_forum_posts( $feed_id ) )

die();

$title = sprintf( __( '%1$s » Forum: %2$s - Recent Posts' ), bb_get_option( 'name' ), get_forum_name( $feed_id ) );

$link = get_forum_link($feed_id);

$link_self = bb_get_forum_posts_rss_link($feed_id);

break;



// Get just the first post from the latest topics

case 'all-topics':

if ( !$topics = get_latest_topics() )

die();



$posts = array();

foreach ($topics as $topic) {

$posts[] = bb_get_first_post($topic->topic_id);

}



$title = sprintf( __( '%1$s » Recent Topics' ), bb_get_option( 'name' ) );

$link = bb_get_uri();

$link_self = bb_get_topics_rss_link();

break;



// Get latest posts by default

case 'all-posts':

default:

if ( !$posts = bb_get_latest_posts( 35 ) )

die();

$title = sprintf( __( '%1$s » Recent Posts' ), bb_get_option( 'name' ) );

$link = bb_get_uri();

$link_self = bb_get_posts_rss_link();

break;

}

}



bb_send_304( $posts[0]->post_time );



if (!$description = bb_get_option( 'description' ) ) {

$description = $title;

}

$title = apply_filters( 'bb_title_rss', $title, $feed );

$description = apply_filters( 'bb_description_rss', $description, $feed );

$posts = apply_filters( 'bb_posts_rss', $posts, $feed );

$link_self = apply_filters( 'bb_link_self_rss', $link_self, $feed );



bb_load_template( 'rss2.php', array('bb_db_override', 'title', 'description', 'link', 'link_self'), $feed );



?>

Member

@kirpiit

I just replaced my 3 files (I use 1.0.2) with those that Kawauso kindly provided, and double checked that all was right.

Yet I get an error http://www.kirpi.it/r/rss/topic/subscribe-to-kirpiforum-recent-topics-by-email

Member

@kawauso

That’s weird. Seems to be throwing <![CDATA in still… could you check if there’s a rss2.php in your template’s directory and if so either change that or delete it? That’s the only thing I can think of that might be causing that. Forgot themes usually copy everything.

Member

@kirpiit

No, there is no rss2.php file in my template. Moreover, I am now just using a plain Kakumei them which I downloaded fresh from the bbpress.org site: the only change I applied was switching the original file inside Kakumei with the one you provided (as well as the other files you provided for other locations inside the install).

Yes, weird.

seh9

Member

@seh9

http://www.ordertheflowersonline.com

Rss feed wont work inthat format.

Member

@kawauso

@kirpi.it Nevermind, ignore what I said earlier. You have a space or a line return before the opening <?php in rss2.php. Seems to be a consistent problem copying from the forums.

Member

@kirpiit

I just double-checked all the 3 files you previously indicated. I downloaded them from my server and inspected them: there are no trailing spaces nor anything. They all start fine with a standard <?php opening.

For a while I hoped it was that trivial, but there must be something else

Member

@kawauso

https://www.yousendit.com/download/YkxKZGlsaTEzS3BjR0E9PQ

Try that. The RSS validation is complaining that the xml header is on the 2nd line, rather than the first, so there’s a line return being inserted somewhere. If FTPing those over the old ones doesn’t work, it’s the dev’s problem

Greg

Participant

@rebootnow