SirLouen (@sirlouen)

Forum Replies Created

Viewing 25 replies - 1 through 25 (of 30 total)
  • @sirlouen

    Participant

    @taliabarlev, have you tried any PDF converter for WordPress instead of looking for a specific solution for bbPress?

    @sirlouen

    Participant

    Yeah, I have it as well. But since they are not going to keep it updated, maybe some fork or alternative is worth being considered?

    @sirlouen

    Participant

    Hey @robin-w Tested but not working ๐Ÿ™
    What can be failing in your idea?

    This doesn’t work either ๐Ÿ™

    Remove NoFollow from BBPress Posts

    Will have to review the code and what’s going on with that filter nowadays

    In reply to: Managing too long URL

    @sirlouen

    Participant

    Ok, the problem wasn’t the rule itself, the problem was the css property: word-wrap was not doing the job with the links

    Word-break seems to have solved the issue now.

    According to this:
    https://developer.mozilla.org/es/docs/Web/CSS/overflow-wrap

    Note: In contrast to word-break, overflow-wrap will only create a break if an entire word cannot be placed on its own line without overflowing.

    This was the problem somehow (not sure how though)

    In reply to: Managing too long URL

    @sirlouen

    Participant

    @webcreations907, did not work as expected ๐Ÿ™ URLS are not being broken with that for some reason

    In reply to: Which widget is this

    @sirlouen

    Participant

    I have upgraded and everything seems fine so far except one very little mistake (don’t need to upgrade for this)

    show-iconfa is showing \f155
    and
    show-iconsu is showing \f147

    And is the other way around

    In reply to: Which widget is this

    @sirlouen

    Participant

    Also, I’m not sure if this is intended but similarly to the other elements this last two don’t have their “show-icon” class with

    font-family: 'dashicons';
    content: '\f155';

    and

    font-family: 'dashicons';
    content: '\f147';

    But could be included with this CSS code (I’ve included in my custom anyway but just to get the same format)

    .sidebar .bsp-st-info-list li.topic-favorite:before {
    	font-family: 'dashicons';
        content: '\f155';
    }
    .sidebar .bsp-st-info-list li.topic-subscribe:before, .sidebar .bsp-sf-info-list li.forum-subscribe:before {
        font-family: 'dashicons';
    	content: '\f147';
    }

    About the other topic here the two snippets (I’m copying a little in the top and in the bottom:

    Around 555

    <?php if ( !empty( $time_since  ) ) : ?>
                            <li class="topic-freshness-time <?php echo $show_iconla ; ?> ">
                            <?php
                                    echo $settings['last_activity'];
                                    echo $time_since ;
                            ?></li>
                    <?php endif; ?>
                    <?php if ( is_user_logged_in() ) : ?>
                            <?php $_topic_id = bbp_is_reply_edit() ? bbp_get_reply_topic_id() : $topic_id; ?>
                            
                            <li class="topic-subscribe"><?php bbp_topic_subscription_link( array( 'before' => '', 'topic_id' => $_topic_id ) ); ?></li>
                            <li class="topic-favorite"><?php bbp_topic_favorite_link( array( 'topic_id' => $_topic_id ) ); ?></li>
                            
                    <?php endif; ?>
                    <?php
                    echo '</ul>' ; // end of '<ul class="bsp-st-info-list">;
                    echo '</div>'; // end of '<div class="bsp-st-title-container">';
            }

    Around 725

    <li class="topic-freshness-time <?php echo $show_iconla ; ?> ">
                            <?php
                                    echo $settings['last_activity'];
                                    echo $time_since ;
                            ?></li>
    
                    <?php endif; ?>
                    <?php if ( is_user_logged_in() ) : ?>
                            <li class="forum-subscribe">
                                    <?php 
                                            bbp_forum_subscription_link( array( 'forum_id' => $forum_id ) ); 
                            ?></li>
                    <?php endif; ?>
                    <?php 
                            echo '</ul>' ;
                            echo '</div>' ; // end of <div class="bsp-st-title-container">
            }
    In reply to: Which widget is this

    @sirlouen

    Participant

    Another tweak (both for st and sf)
    You could move from 556 to 562

    over the 555:
    echo '</ul>' ; //end of '<ul class="bsp-st-info-list">'; ?>

    To have all “li” in the same “ul”

    (Same in line 725)

    Remember to close some of the ?> lingering afterwards ๐Ÿ™‚

    In reply to: Which widget is this

    @sirlouen

    Participant

    484 and 652

    echo '<div class="widget bsp-st-title-container">';

    echo '<div class="widget bsp-sf-title-container">';

    In reply to: Which widget is this

    @sirlouen

    Participant

    Also, within bsp-sf-title-container (line 652)

    In reply to: Which widget is this

    @sirlouen

    Participant

    Thanks @robin-w

    Just a little tweak, with the bsp-st-title-container class in includes/widgets.php line it would be great that you include the widget class to keep it WP compliant.

    @sirlouen

    Participant

    My bad: I’ve been checking more thoroughly this plugin and I’ve found that the “moderation” for users is not applied in their profile but straight in their replies and topics, which is even better because this makes it an even easier moderation

    Thanks for the call!

    @sirlouen

    Participant

    Great, thanks ๐Ÿ™‚
    It’s easier than I expected

    @sirlouen

    Participant

    Thanks @robin-w but this plugin is an all or nothing. All approved or anyone approved to post.

    I’m going to try to introduce some extra features in that plugin. Let’s see how this goes.

    In reply to: Managing too long URL

    @sirlouen

    Participant

    Good idea, I’m going to test it

    @sirlouen

    Participant

    I have a bad omen for my question after finding this:

    Mark All Forums As Read

    @sirlouen

    Participant

    I’ve put that change in my site and submitted the patch in the trac. The best thing is that you reported this 4 months ago!! https://bbpress.trac.wordpress.org/ticket/3297

    @sirlouen

    Participant

    Found the issue: https://bbpress.trac.wordpress.org/ticket/3356

    This can be closed now.

    @sirlouen

    Participant

    @robin-w This is not working as expected and I think there is a bbpress bug. I’m currently testing in my localhost but I think I will publish on trac what I’m finding

    @sirlouen

    Participant

    I’ve checked the bbpress code and it seems that something is hindering my site
    Theorically it shall show the last replay by default without the need of a plugin because it technically should be saving the last active id in the forum post meta field _bbp_last_active_id

    Not sure what can be hindering my forum behaviour :S

    @sirlouen

    Participant

    By the way, in my forum template I’m using

    bbp_forum_freshness_link

    @sirlouen

    Participant

    @robin-w : for some strange reason, last reply has automatically switched to last post again. It doesn’t seem that the plugin is switching this.

    In fact, it doesn’t work the option:
    2. Topic Title Click to show Title on forums pages

    Now I’m not 100% sure if it worked before, I’m 50% confident I saw at some point last replay in the forum index. But I’m checking the “Freshness Display” tab menu and it doesn’t show explicitly to switch between “last reply” and “last post”.

    @sirlouen

    Participant

    It works, now this really reminds me my old SMF forum.

    @sirlouen

    Participant

    Really interesting plugin
    I did not even modify the Freshness Display and it switched to last reply by default.

    I’m going to help you out with the translation to Spanish of that plugin.

    By the way, for code improvements, how do you track changes? do you have public repo for the plugin or using WP SVN?

    @sirlouen

    Participant

    Here you can see it

    images

    I’ve temporarily solve it (or maybe permanently) with:

    .bbp-topic-revision-log-item .bbp-author-avatar {
    	display: none;
    }
Viewing 25 replies - 1 through 25 (of 30 total)