[_ck_]

Ah I think I see the problem.

Unlike all the other browsers, Opera has taken it upon itself to cache the javascript request instead of actually fetching it each time (this is one way it cheats for speed).

Will add some code for a unique URL to force it to work.

okay, here you go, v0.24

http://ckon.wordpress.com/files/2007/08/bb-polls.txt?v024

should fix the issues with opera (and anything else caching)

I’ve also now added hidden near the top of the code a “test_mode”

If you change “test_mode” to “true” it will allow you do keep voting on any poll for testing purposes. You can switch back and forth to view/vote etc. Obviously change it back on a live site with members or people will be able to stuff the ballot box.

Keep in mind that previous poll data may have been made invalid by the bug in opera so start with a fresh poll. Do not keep re-using the old polls for testing with v0.24. I have not changed data structures but if the data got inserted wrong, it could be invalid for that topic.

(I’ll make a “delete poll” option soon for administrators.

The space it takes is trivial, so don’t worry about that)

[_ck_]

Yeah sorry about that.

I just checked opera on 0.22 / 0.23 and the ajax vote is broken on that. Works in IE + firefox though.

Opera still doesn’t have any level of javascript debugging does it?

I just realised there’s also a problem in that you can vote without anything selected which is something I somehow overlooked entirely.

[_ck_]

Wasn’t aware of that one. I will look into it.

I’ve dropped it to the older escape routine.

Will just have to see if it works with non-english pages or not.

Is *anyone* else experiencing what Null is showing?

I cannot reproduce it.

v0.22 now adds ajax-ish voting so it’s almost entirely ajax except for the poll setup form which will take much more work than I am willing to do right now. (also cancel button added to poll setup)

http://ckon.wordpress.com/files/2007/08/bb-polls.txt?v022

It’s getting really good, ready for the the members to give it a go.

Can’t believe I didn’t have any code at all for this three days ago and its over 15k now with nearly 400 lines.

Now I need someone to come up with some pretty CSS styles.

[_ck_]

That’s the default bbpress template right?

I have a very similar setup but not seeing any of that.

Can anyone else report on this issue?

0.22 will be out shortly, I have ajax voting done.

Gotta fix how it calculates totals for multiple answer votes.

[_ck_]

Null, so that is v0.21?

What OS are you on windows/mac

What version of opera is that?

Can you do a quick test in IE / Firefox for me and see if it does the same?

Yes I was thinking the same about the cancel button, will add shortly in future version. Working on the ajax-ish voting right now.

ps. all the button text, actually ALL the text is completely editable at the top

[_ck_]

I only used a table to match what is already being used on that page by default and there may be future structures that need a table.

The svn doesn’t seem to be updating the versions on the extend page here so here’s a direct version:

http://ckon.wordpress.com/files/2007/08/bb-signatures.txt?v011

[_ck_]

To change text you either have to use “pre_post” which is a permanent change saved back to the database (ie. auto close tags) or “post_text” which only affects the outputted text and leaves the source alone (ie. smilies typically use this cause you don’t want the image tags back into the text upon re-editing).

IMHO “post_text” is an “expensive” operation in that it has to be generated on the text each and every time it’s displayed but sometimes there is no other choice.

If you are asking how to automatically insert the button, that’s very tricky because somethings still don’t have hooks in bbpress, ie.

https://trac.bbpress.org/ticket/720

(ironically that’s where I’d put a quote button)

The trick is to start a new post with the old text as a quote. I have no idea how that would be done in bbpress because I don’t think you can have existing text on a new post, old an old one, and you really don’t want to pre-create a post in case the user cancels.

I’d love to see this plugin happen, I just don’t know enough to help you more – hope someone else can help.

ps please make it trim the old post for people who like to quote posts, who quote posts, who quote posts and it ends up being 10 pages long, LOL!

[_ck_]

Ah. See if it goes away with 0.21 ?

php.net says mysql_real_escape can cause a warning in certain situations but it shouldn’t be fatal – I think I can block that with “@”. Or I can drop to the older mysql_escape_string.

[_ck_]

Please try again with v0.21

https://ckon.files.wordpress.com/2007/08/bb-polls.txt?v021

Many little bug fixes.

mysql_real_escape_string requires php >= 4.3.0

is this a problem for anyone?

php prior to 4.3 has lots of security issues

v0.21 looks/works fine in my opera 9.0

Many thanks for all the beta testing, I think we’re stable now in all modern browsers…

[_ck_]

Whoops, I finally considered testing it in internet explorer and I can see it has a few issues – sorry about that. Working on the bugs now…

[_ck_]

Moderators do see the link, you just don’t see it on your own posts, there’s no point in reporting yourself, LOL!

[_ck_]

Do you mean inside the edit profile page?

You’d need to reduce the <table width="100%">

but maybe also textarea style="width:90%;"

Are you using a custom template? Seems to work fine in the few templates I’ve tried.

If you still have trouble, post a screenshot image if you can.

I am now removing width="100%" from the new/next version.

[_ck_]

I’ve tested this now up to the bbpress trunk and it seems to work fine.

Try the latest:

https://bbpress.org/plugins/download/report-post.zip

Make sure you are editing post.php in your bb-templates or my-templates?

Unfortunately there is no hook for me to place it automatically in post.php on that info line. Wish there was.

[_ck_]

Sorry I didn’t see your bug report until just now.

I am working on this tonight and will have a working version posted soon (including translation hooks for you).

[_ck_]

I am pleased to announce that v0.19 now supports ajax-ish™ behaviours on all actions except form submits (saving data). The view poll results actually happens with a real update, if votes happen while you are waiting to vote and you go check, they will increase. I might even add an auto-refresh to it (every 30 seconds?) to freak people out.

http://ckon.wordpress.com/files/2007/08/bb-polls.txt?v020

You can also turn off ajax entirely in the settings and if there’s no proper javascript support it falls back to regular actions of course.

I’ve only tested on firefox out of exhaustion right now, so I’ll need feedback from other browsers. Ajax on submits will take quite a bit more research for me, never done it before and I’ve heard it’s problematic on different browsers.

@mazdakam, sorry about the float:left – I used it to try to make it behave with some other templates I was testing. I realise now how that would messup your configuration…

[_ck_]

Good advice and very clear points. Not worth the risk.

I’ve been looking at some of their templates and it’s not that amazing anyway. They also use tables. If I clear up my layout and document it well, I am sure some css gurus out there can make something even better.

In other news I fixed the nagging refresh bug

http://ckon.wordpress.com/files/2007/08/bb-polls.txt?v018

(the post data that’s left on the page when you hit f5) but I hate the way it has to be done (redirect after processing the post data, back to the same page – that’s twice the load for bbpress – can’t find any other documented solutions).

I think my next code attempt will be to make it load in place (like ajax but not really ajax).

[_ck_]

Okay point taken.

Like I said earlier, I will give them several default styles to choose from the admin page (basically the top 10 that other people come up with). It’s too tedious to just change each bar colour. Someone can make a style where they all are the same colour or alternating row colours.

[_ck_]

So what are the ethics involved in making the styles compatible with polldaddy’s, so that all of their skins could be used?

Is that “legal” and if so, is it still “ethical” ? Are styles “copyright” ? I vaguely remember reading that “look & feel” cannot be copywrited.

I’ll consider doing it if that would be desirable and still ethical.

[_ck_]

The CSS is fully editable for the bar colours. You can even make the bars fancy images if you so desire.

I guess I am going to have to make a proof-of-concept to show people that it doesn’t have to look anything like my default. I can even make it look like polldaddy.

ps. @fel64 v0.17 now tricks bbpress in keeping the poll data completely unserialized until the plugin actually needs it (easy fix). It still has bbpress cache the data with the topic for fast loads. What’s nice about this is the topic title “[poll]” can still tell if the topic has a poll by just checking for the object without deserializing it (ie. $topic->poll_options) – oh it’s also completely compatible with any currently saved poll data and can deal with it already being unserialized, it just fixes it on the next vote

[_ck_]

example of when serializing is bad:

a loop of 50 topics being displayed where the data has to be unserialized each and every time because of the way the data is fetched – it’s very easy to accidentally make this happen

fortunately polls are only displayed on the topic page where the data has already been fetched from the db and deserialized once

What bothers me even more however is using things like is_topic() which can get caught within the topic list loop on the front-page/forum page, because of how much work it does and how repetitive it is without being cached.

Unfortunately I cannot figure out a less intensive way and it can’t be cached. bbpress should be storing a simple string flag for it the moment it determines its heading towards that template, not post-processed by looking at the filenames. The difference in overhead is significant.

ps. actually, I just realised I am doing that bad version of deserializing. I have to trick bbpress not to deserialize all that data… will work on it

[_ck_]

Great work!

I will make one important suggestion however.

There is too little contrast between the background colours and foreground text colours.

For someone with poor eyesight problems (like me) this makes it very difficult to focus and read all the text. Either make the (link) text darker or make it another darker colour (ie. navy blue)

[_ck_]

mazdakam, try this for better translations?

http://ckon.wordpress.com/files/2007/08/bb-polls.txt?v016

I’ve put ALL the text near the top for easier editing.

@Null, I’m not going to spend too much time “ajax-ing” it.

But I think i can make all the actions happen without reloading the page. I’m going to simply replace the contents in the <div id=poll></div> dynamically. Should be enough to keep everyone happy.

[_ck_]

Sorry, I have to learn how those translation calls work, never used them before.

I wanted to allow the text changes to be made within the admin menu so no external files have to be edited.

ah, found the instructions:

https://codex.wordpress.org/Localizing_WordPress#Localization_Technology

I’ll have 0.16 up shortly with that changed.

[_ck_]

One thing that’s probably holding that back and bugs me in that templates are not re-used in bbpress, is for example how post-form and edit-form should be integrated with maybe one or two conditional statements if necessary.

I guess ajax post deletes are a lot easier than ajax posting/editing.

Then there is the code block in front-page, forum.php & view.php which shows sub-forums, stickeys and posts. It’s virtually identical in each template but if you want to change one, you got to go to all three and change them in each place, the exact same code. It should be a sub-template, which of course I could hack in on my own but should be part of the core. Change it in one place, changes everywhere you see it.

[_ck_]

“get_topic_last_post_link()” and it’s dependency “get_post_link()” relies on two important things which can be easily thrown off in bbpress or it’s db

1. if you are using a plugin or other code to change the number of topics shown on the front page or forum pages vs the topic page, get_topic_last_post_link() will calculate the last post incorrectly. This is because there is only one universal setting in bbpress right now for the number of items per page (there should be an array in the core so limit can be different than limit and then get_topic_last_post_link() will know to look at the destination limit instead of where it’s coming from)

see my bug fix for custom limits for each page here:

https://bbpress.org/forums/topic/custom-topics-count-for-different-pages-that-doesnt-break-last-post

it basically forces get_post_link to recalculate

2. get_topic_last_post_link() relies on the post_position in the bbpress table – which can get messed up if there are deleted posts, moved/merged posts, or recounts

Recounts does not attempt to recalculate and resave the post_position. This would have to be written. It basically would have to look at all posts in a topic, sort them by the desired date order, and then renumber them.