Problem Solved: I originally had set up the forums so that after 25 minutes the post would be locked. I set it to a much higher number (99999) and subscribers can now edit their posts.
Must be something to do with how BBPress handles the calculation of the time limit.
I am also having this problem. User Role Editor shows me that they do have permission to Edit Topics and Replies.
