Robin W (@robin-w)

Forum Replies Created

Viewing 25 replies - 13,351 through 13,375 (of 14,204 total)
  • @robin-w

    Moderator

    glad to have someone else looking !

    My ajax is hopeless !

    Your solution is valid, but digging for it produced some code issue

    we have several issues here

    firstly the filter call is wrong in the code ie

    bbpress/includes/topics/template.php has two errors

    function bbp_get_topic_subscription_link( $args = array() ) {
    ......Parse the arguments......
    		), 'get_forum_subscribe_link' );

    so the function is ‘get_topic_subscription’ but the parse argument reverts to ‘get_forum_subscribe

    whilst it doesn’t affect this issue the error is repeated for favorites in the same file

    function bbp_get_topic_favorite_link( $args = array() ) {
    ..........), 'get_forum_favorite_link' );
    

    needs changing to ‘get_topic_favorite_link’`

    This doesn’t affect the issue as such, other than the filters above are wrong.

    But filtering bbp_get_topic_subscription_link is totally pointless, as it immediately calls
    ‘get_user_subscribe_link’ which them resets the |, so whilst the filter seems to correct it once, any click just resets it.

    So your filter to get_user_subscribe_link is the correct one, but for the wrong reason.

    Really the code needs to have the filter in one place only (suspect user)

    Anyway the solution for @majid436 is as you suggest

    function hide_before3 ($args = array() ) {
    $args['before'] = '';
    return $args;
    }
    add_filter ('bbp_before_get_user_subscribe_link_parse_args','hide_before3');
    

    @robin-w

    Moderator

    it will not defeat me, but just need to lick wounds for a few days, then I’ll be back !

    @robin-w

    Moderator

    I’ve just spent two hours debugging this, I’ve found three errors, fixed it once only for it to come back.

    I give up for the moment !

    @robin-w

    Moderator

    Glad you’re fixed !

    @robin-w

    Moderator

    I think that you will struggle to maintain a bbpress + version, and that the ‘+’ will just get bigger and bigger and bigger. I probably have 20+ plugins I could write to do things that people ask for on the forums.

    Many people just want a particular part that suits them, and the bbpress philosophy is to keep it ‘skinny’ and let people use plugins.

    Making a big fat version would make it really hard to develop.

    The real problems are two:

    1. That people aren’t aware of the skinny philosophy – maybe I’ll put something at the start of the documentation to make this clearer.
    2. People aren’t aware of what plugins are available and which work. This is really because you have to have a problem or know what you want before you look for a plugin. This is a bit like buying a car with no add-ons/accessories list. So no-one tells you that electric windows are available, so you look for an expensive air-conditioning system because you don’t know how to open the windows. Solution is that we need to create a plugin list that starts with what it does, not with the plugin name or with searches for tags

    eg

    bbpress plugins Where to download
    Add quote feature http://www.dev4press.com/plugins/gd-bbpress-tools/
    genesis compatibility https://wordpress.org/plugins/bbpress-genesis-extend/
    Move one forum to another https://github.com/pippinsplugins/bbPress-Export-and-Import
    private messaging https://wordpress.org/plugins/bbpress-social-network/
    email notifications (topics/replies) https://wordpress.org/plugins/bbpress-notifications/
    email notifications (topics/replies) https://wordpress.org/plugins/bbpress-notify/
    add a signature https://wordpress.org/plugins/bbp-signature/

    I am just about to start one, so if you want to add the plugin name and what it does to this thread, I’ll get a list going.

    @robin-w

    Moderator

    Ok, I’ve done a version 2 with a settings page that lets you select from :

    Send non-logged in users to any page you wish
    Lets you set a message for the freshness column
    Hide topic and reply counts
    show descriptions
    Remove the ‘private’ prefix from the displayed titles

    So hopefully more friendly and flexible.

    Give it a try

    I have left the old version on the website in case you need to revert back.

    Otherwise let me know if it breaks anything or I can improve it.

    I’ll load it to the wordpress plugins page in a few days

    url as before http://www.rewweb.co.uk/private-forums-visibility/

    @robin-w

    Moderator

    ” just a little bit overworked and start making mistakes” – I know how you feel !!! πŸ™‚

    @robin-w

    Moderator

    weird, I’ll try it on my test site when I get a moment !

    @robin-w

    Moderator

    The answer is yes, but I’d need to take a look at the plugin, and will try and do so over the next few days

    @robin-w

    Moderator

    Phew ! I read the first post and thought oh dear, then your second came through, glad it’s working.

    I’ll add a settings page to the code so that you can set which page it goes to for future users.

    @robin-w

    Moderator

    1. if you need these adding to bbpress roles, then as per previous:

    “what capabilities do you need for the other role?

    see

    https://codex.bbpress.org/bbpress-user-roles-and-capabilities/

    It’s quite east to add, just let me know what you need.”
    come back, and I’ll do a quick plugin.

    2. On your rank thing, can you specify

    the rank names you want
    what levels you want them at eg 50 posts
    what counts as a post – ie topic or topics and replies

    and I’ll tinker with the posts plugin to display this instead as a one off, and maybe cut it into a more general plugin later

    In reply to: 90 second post time

    @robin-w

    Moderator

    I’d check to see if two plugins are conflicting or theme issue, or if it is server related.

    Check other plugins

    Check that no other plugins are affecting this.

    Turn off all other plugins apart from bbpress, and see if that fixes the problem. If the problem is resolved, add back one at a time to see which is causing the conflict.

    Check themes

    If plugins are not the cause, then it may be a theme issue. Switch to a default theme, such as twentytwelve, and test.

    Come back and tell us if any of those speeded it. If so then you know the problem, if not contact your service provider as it should be a few seconds at most.

    @robin-w

    Moderator

    Sorry to hear this.

    Try it with a default theme such as twentytwelve.

    If this fixes, then it is a theme issue.

    @robin-w

    Moderator

    Have just built a plugin to do this.

    go to

    bbp Private Forums Visibility

    In reply to: User Permission

    @robin-w

    Moderator

    keep asking !

    @robin-w

    Moderator

    ahh! that’s it

    difference between

    ‘bbp_before_get_topic_subscribe_link_parse_args’

    and

    bbp_before_get_topic_subscription_link_parse_args

    So

    function hide_before2 ($args = array() ) {
    $args['before'] = '';
    return $args;
    }
    add_filter ('bbp_before_get_topic_subscription_link_parse_args','hide_before2');
    

    will do it !

    @robin-w

    Moderator

    what capabilities do you need for the other role?

    see

    https://codex.bbpress.org/bbpress-user-roles-and-capabilities/

    It’s quite east to add, just let me know what you need.

    On ranking, you can have no. posts quite easily using

    https://wordpress.org/plugins/bbp-topic-count/

    @robin-w

    Moderator

    I’ve had a look, but I can’t find what is doing this – must be buried deep

    If you keep toggling the | comes back, so my original code isn’t doing anything.

    The codes resolves as

    <span id=”subscription-toggle”>
    |
    <span id=”subscribe-2072″>
    Click to receive an email notification when a member responds below

    so it’s in the subscription part, but not part of the url.

    @robin-w

    Moderator

    By the way this does both the private forum visibility and the sub forum description !

    @robin-w

    Moderator

    Ok, so my plugin I taking longer to develop than I thought – but they always do!

    But I have been through the code needed for what you are after, and it neatly cuts into a plugin of it’s own, so that is what I’ve done.

    The plugin and instructions are here

    bbp Private Forums Visibility

    Read you way through, and let me know if you have any difficulties.

    Because I have cut this for you, I haven’t made it very pretty as a plugin, so there aren’t settings for the permalink – you’ll see what I mean when you read the link.

    If this doesn’t do what you want or you find issues, please come back, I should be able to fix fairly easily whilst the code is fresh in my brain.

    Have a great weekend !

    @robin-w

    Moderator

    hmmm.. it is the same function that does both, but as I said before normally it is blank, so my solution above should not have worked, but did.

    Can you send me a link to that page, and I’ll take a look.

    @robin-w

    Moderator

    ‘…as I am not really firm in php code ‘ – your coding skills don’t look at all bad to me πŸ™‚

    Without testing, that looks fine to me – give it a go.

    You could choose to just edit that file, but if you do, keep a note of what you changed, as bbpress updates will overwrite it – purists will say you should never alter core files, but as this is already a plugin, I am less fussy (expecting to be criticised for this!), but do know what you’ve changed.

    To do it “properly” you’d need to either

    create these as new widgets by copying the code to your functions file and renaming it.
    create this as a plugin.

    If you need help in how to rename come back, and I’ll make a list of what you need to change, but you’ll need to be a bit patient, as I have loads of queries os, and you’ll need to join a queue !

    In reply to: bbpress login widget

    @robin-w

    Moderator

    bbPress is tested against all the common browsers, so unlikely that it is a default issue (indeed mine works fine on all those browsers)

    Could be any number of things, but as always start by eliminating plugins and themes viz ;

    Check other plugins

    Check that no other plugins are affecting this.

    Turn off all other plugins apart from bbpress, and see if that fixes the problem. If the problem is resolved, add back one at a time to see which is causing the conflict.

    Check themes

    If plugins are not the cause, then it may be a theme issue. Switch to a default theme, such as twentytwelve, and test.

    Come back and let us know if that helped, and what the issue was, or if still happening.

    In reply to: User Permission

    @robin-w

    Moderator

    ‘Sorry still newbie to all these codes thing πŸ™‚ ‘ – Don’t worry I was there only last year, you’ll soon pick it up.

    Start with

    https://codex.wordpress.org/Functions_File_Explained

    So you need to add this to your theme’s function file.

    If you are using a main theme, then any updates to the theme may overwrite your addutions, so a child theme is better. However if you put it in your main theme, just keep a note of the changes so that you can add them back if needbe.

    Ideally you should create a child theme – google ‘child theme videos’ and you’ll see how to create this – it is very simple, and just lets you ‘add stuff’ to your main theme without any risk of losing it.

    Have fun !

    In reply to: User Permission

    @robin-w

    Moderator

    Try

    function annointed_admin_bar_remove() {
            global $wp_admin_bar;
    
            /* Remove their stuff */
            $wp_admin_bar->remove_menu('wp-logo');
    }
    
    add_action('wp_before_admin_bar_render', 'annointed_admin_bar_remove', 0);

    (stolen from the wordpress support forum, so haven’t tested)

Viewing 25 replies - 13,351 through 13,375 (of 14,204 total)