Topic: possible error in topic_link() function · bbPress.org

Skip to:: Content; Pages; Categories; Search; Top; Bottom

possible error in topic_link() function

C Bog
Member

@bogdancismariu

15 years, 7 months ago

i think that the following line:

echo apply_filters( 'topic_link', get_topic_link( $id ), $id, $context );

should be replaced with this line:

echo apply_filters( 'topic_link', get_topic_link( $id, $page, $context) );

this is inside the topic_link() function, in functions.bb-template.php file

i use version1.0-alpha-6 and this line is number 855.

please correct me if i’m wrong.

Viewing 3 replies - 1 through 3 (of 3 total)

chrishajer
Participant

@chrishajer

15 years, 7 months ago

Can you explain what problems this line is causing, and what changing the line does to fix it? How did you find this problem?

C Bog
Member

@bogdancismariu

15 years, 7 months ago

i wanted to modify my template, in order to send the user to the last page of the selected topic. (this was before i discovered the topic_last_post_link() function).

in order to do this, i manually computed the last page number and send it to topic_link() through the $page parameter. nothing happened so i looked at the code and found the error i’ve mentioned. after replacing that line with the one i’ve suggested, everything seemed ok.

any thoughts?

chrishajer
Participant

@chrishajer

15 years, 7 months ago

I think you should file a bug and a patch at https://trac.bbpress.org/ . They will decide there if it’s valid or not.

Viewing 3 replies - 1 through 3 (of 3 total)

You must be logged in to reply to this topic.