bbPress.org

Have you tried recounting in the admin?

Only 24 MB of RAM for PHP?

If you are using my “topics per page” plugin there may be a bug as far as which page you are sent to. Are you using that plugin?

I guess it could also calculate the page incorrectly if there are deleted posts and the post count is wrong.

You definitely need to accomplish a recount somehow. Let me study the mysql.

I am having this problem too. You can check it at:

http://e-motion.lt/bbpress/topic/12/page/3

Go to page 4. The thread has one post deleted – #24.

I am using bbPress 1.0.2.

_ck_,

Yes, I’ve tried to do a recount, but it had no effect on this issue.

For this example, unfortunately, the thread in given link is an active discussion and the problem vanished when one reply was written. It will reappear when someone writes a reply last on that page. I wonder how it will be with two deleted posts, not one…

No, I do not. I have following plugins:

Akismet

Allow Images

Avatar Upload

BBcode Buttons Toolbar

BBcode Lite

bbPM

BBVideo

Bozo Users

Hello Louie

Human Test for bbPress

Instant Password

Skip Akismet

SourceCode Highlighter

You know what, this is an inherit flaw with bbpress that I think I mentioned elsewhere years ago.

It never recalculates post-position when there are deleted posts, yet it relies on that post-position to find a specific posts’s page.

See this is how it calculates the page

function get_post_link( $post_id = 0 ) {

$bb_post = bb_get_post( get_post_id( $post_id ) );

>>>>>>	$page = bb_get_page_number( $bb_post->post_position );

return apply_filters( 'get_post_link', get_topic_link( $bb_post->topic_id, $page ) . "#post-$bb_post->post_id", $bb_post->post_id );

}

and this is how it calculates that page

return intval( ceil( $item / $per_page ) );

so it’s $bb_post->post_position / $per_page

always, regardless if there are deleted posts in the way, which is why it can be “short” when calculating the last page(s) on a longer topic with deleted posts.

The solution is that post-position has to be recalculated when a post is deleted. The only side effect is that for admin, jumping directly to a deleted post would not work, you’d have to find it manually.

bbPress never, ever, re-calculates post-position, even on a recount, if I am not mistaken.

There is one tiny work-around we can do.

For the LAST POST calculation, we can intercept that and subtract the number of deleted posts from the post-position. Hmm, actually wait, is it subtract or add. I have to investigate this a bit and think out the logic.

Here’s a simplified example of what I think is happening internally.

Let’s say for ease of understanding there are TWO posts per page.

And there are 7 posts in this particular topic example

|1 2| – |3 4| – |5 6| – |7|

so there are 4 pages (each | | is a page)

In this example, the post numbers are also the post-position.

Now let’s say a mod deletes post number 4

|1 2| – |3 5| – |6 7|

Should only be three pages.

But bbPress is stupid by default, post-position is never recalculated so those post numbers still represent post position in this example.

bbPress DOES track number of posts in a topic, even when deleted.

So requesting a link to the last post in the topic, regardless of post-position, WILL be calculated correctly, and return page 3.

However, if it specifically asks for a direct link to post 7 and not the last post in the topic, this is what happens.

Post 7 is post-position 7

posts per page is 2 per page

ceil( $post_position / $per_page )

7 / 2 = 3.5, ceil of 3.5 = 4

So it will ask for page 4

Page 4 does not exist in the topic.

The link may be created but the link is bogus and will not work, it will either return you to the first page of the topic, or maybe the front page of the entire forum.

I am now trying to recreate the problem. I was unable to do so on new topic and can’t remember exactly what I did last time. It just recounts all post numbers and everything works fine. It is stupid of me, but somehow I think that I may have tampered with the post physically – on phpMyAdmin. I am not sure about this, I do lots of stupid things.

I have now temporarily closed this topic (it is most active one in my whole forum) and added some posts to replicate the problem:

http://e-motion.lt/bbpress/topic/12?replies=80&message=closed

Forum says there are 81 posts and 5 pages. On page #2 post #24 is missing.

Page #5 is “empty”. If I unlock the topic, reply form is on page #5 and not #4, where the last post is.

Sorry, I am not so good with CMS-related stuff.. I do know some PHP and MySQL, but some basic help may be needed.

P.S. Very nice to hear you also have an e-bike! I have been riding this one for a while: http://www.youtube.com/watch?v=fXsE5NNfC7w

And hopefully will ride a DIY electric scooter in couple of weeks.

You’ve definitely done a recount in the admin section?

Because the 81 on the topic list is very wrong.

Do a recount in the admin.

If it still shows 81, I want you to delete one of those last filler posts you made and then undelete it. That will force a recount.