bbPress.org

Thanks Robin. That’s given me something to work with.

As it stands, this will include the current forum in the breadcrumb if the search is executed from a specific forum and the result set is not empty. That is certainly one of the cases addressed.

But if the search is executed from the main index page, and the result set is not empty, instead of the breadcrumb trail including just Forums > Search > etc., it will include the name of the the first forum that produced a search hit (and obviously not all, where there may be several hits in different forums), which is not really the intent.

If the search set is empty, however, the name of the forum from which the search was conducted is still missing and I’m not sure I can work out how to get around that, because your code is using one of the search hits to work out what forum to add to the breadcrumb. If the search set is empty, how then can I work out where I’ve come from? I think I’m going to have to know this to even fix the first problem above.

Is there a concept of something like a global variable here? Can we set the $forum_id variable any time we navigate to a particular forum and just call on that from where ever we are if needed?

I think it will be the case of the empty search where this will come in most handy, because the reader can quickly flick back to the forum in question and search again, rather than having to go back to the main index page and navigate back to the forum they were working with if they, for example, have just mistyped a search string.

Thanks again. I had no idea where to even begin…

Ahh! To the reader left as an exercise it is!

Thanks, I’ll see how I go.

Working with your original solution, your subsequent advice, playing with code segments from relevant template files, and a bit of dumb luck, the following augmented version of your function seems to work:

function rew_breadcrumb_search ($crumbs) {
	//create a new array
	$new_crumbs = array() ;
	$first_pass = true;
	$augment_breadcrumbs = true;
	//find the forum from the first item in results
	if ( bbp_has_search_results()) {
		while ( bbp_search_results() ) : bbp_the_search_result(); 
		$type = get_post_type() ;
		if ($type == 'topic' ) $forum_id = bbp_get_topic_forum_id() ;
		if ($type == 'reply' ) $forum_id = bbp_get_reply_forum_id() ;
		if ( $first_pass ) {
			$first_pass = false;
			$last_forum_id = $forum_id;
		} elseif ( $forum_id !== $last_forum_id ) {
			$augment_breadcrumbs = false;
		}
//		if (!empty ($forum_id)) break ;
		endwhile ;
	}
	//cycle through the crumbs until we find search
	foreach ($crumbs as $crumb=>$data) {
		//shouldn't really need to do this inside the loop, but the alternatives crashed	
		if ( $augment_breadcrumbs ) {
			if (strpos($data, 'search') !== false) {
				//If the forum ID exits, add the breadcrumb
				if ( $forum_id && is_numeric( $forum_id ) ){
					//Use the Forum ID we found in the search result
					$new_crumbs[] = '<a href="' . esc_url( bbp_get_forum_permalink( $forum_id ) ) . '" class="bbp-breadcrumb-forum">' . bbp_get_forum_title( $forum_id ) . '</a>';
				} else {
					//The search result was empty, so we need to get the Forum ID from the search request(?)
					$forum_id = sanitize_title_for_query( $_GET['bbp_search_forum_id'] );
					if ( $forum_id && is_numeric( $forum_id ) ){
						$new_crumbs[] = '<a href="' . esc_url( bbp_get_forum_permalink( $forum_id ) ) . '" class="bbp-breadcrumb-forum">' . bbp_get_forum_title( $forum_id) . '</a>';
					}
				}
			}
		}
			$new_crumbs[] = $data ;
		}
	return $new_crumbs ;
}
add_filter ('bbp_breadcrumbs' , 'rew_breadcrumb_search' ) ;

It does seem a little complicated, but all my attempts to cut out bits that don’t immediately look necessary breaks things, so I have what I have—but it does produce the desired outcome.

Thanks for your help. It was very much appreciated.