I seem to have a problem with Post Notification being installed on multiple bbPress installations that use the same user table (from one WordPress site to enable single sign-on). According to WP/bbP this should work as expected, but now:

My forum users get notification e-mails for topics from the wrong bbPress installation.

I had a quick look at the PN code and I think the problem that's causing this behavior is that PN checks if the ID of an updated topic is in the user's favorite topics list. Unfortunately with two bbPress installations topicIDs are not unique any more and therefore the wrong users get notification e-mails.

Has anyone experienced this before? Is my assumption correct? Is there a way to fix this?

Thank you very much in advance!
Holger

----

Edit: Everyone, I'm sorry. This was probably the wrong place to post my problem. I found out that bbPress stores its favorite topics in the "user meta" table of the associated wp database under the key "bb_favorites". Well, if several bbPress installs do this there are obviously going to be uniqueness problems.

A big thanks for your modified notification code, it's exactly what I needed...

<div id="discussions">
<h2>Forums</h2>
<table id="latest">
<tbody>
<tr>
<th>Main Theme</th>
<th>Topics</th>
<th>Posts</th>
</tr>
<tr class="%BBLD_CLASS%">
<td>%BBLD_FORUM%</td>
<td class="num">%BBLD_TOPIC%</td>
<td class="num">%BBLD_POST%</td>
</tr>
</tbody>
</table>
</div>


function auto_add_favorit_profile() {
global $user_id;

if (bb_is_user_logged_in()) {
$checked = '';
$unchecked = ' checked="checked"';
$user = bb_get_user($user_id);
if (!empty($user->auto_add_favorit)) {
$checked = ' checked="checked"';
$unchecked = '';
}
echo '
<fieldset>
<legend>Add my threads automatically to my favorites</legend>
<p>Check this option to add all your threads or threads where you have posted something to your favorite list.</p>
<table width="100%">
<tr>
<th width="21%" scope="row">Activate:</th>
<td width="79%">
<input name="edit_auto_add_favorit" id="edit_auto_add_favorit" type="radio" value="1"'.$checked.' />
</td>
</tr>
<tr>
<th width="21%" scope="row">Deactivate:</th>
<td width="79%">
<input name="edit_auto_add_favorit" id="edit_auto_add_favorit" type="radio" value="0"'.$unchecked.' />
</td>
</tr>
</table>
</fieldset>';
}
}

http://bbpress.org/plugins/topic/auto-add-favorites/

Can you look please at that. Thanks in advance.

(I can't edit my old post, so sorry for the inconvenience with the extra code...)

<?php
/**
* Plugin Name: Post Notification
* Plugin Description: Sends a Notification email if there's a new post to a favorite topic.
(Modified Version 1.4 with Post Content included in E-Mail)
(And modified to send mail in utf8 format so danish, swedish, russian etc. characters display correctly).
Also modified so user can select whether to get a mail on favorite topics or all topics.
Changed subject of email to show which topic is updated - and from: is now set to the username of the poster instead of the forum name.
* Author: Thomas Klaiber
* Author URI: http://thomasklaiber.com/
* Plugin URI: http://thomasklaiber.com/bbpress/post-notification/
* Version: 1.4.x
*/

function notification_all_is_activated($user_id) {
$user = bb_get_user( $user_id );
if ($user->favorite_notification_all) : return true; else : return false; endif;
}
?>

If i uncheck the boxes and save then it again shows as checked.

Any clue?

These are the modifications I've made:

- Send mail in UTF-8 format so Danish, Swedish, Russian etc. characters display correctly.
- User can select whether to get a mail on favorite topics or all topics.
- Changed subject of mail to show which topic is updated (forum-name:topic). Also 'from:' is now set to the username of the poster instead of the forum name, which makes your inbox so much more tidy.

<?php
/**
 * Plugin Name: Post Notification
 * Plugin Description: Sends a Notification email if there's a new post to a favorite topic.<br>(Modified Version 1.4 with Post Content included in E-Mail)<br>(And modified to send mail in utf8 format so danish, swedish, russian etc. characters display correctly).<br>Also modified so user can select whether to get a mail on favorite topics or all topics.<br>Changed subject of email to show which topic is updated - and from: is now set to the username of the poster instead of the forum name.
 * Author: Thomas Klaiber
 * Author URI: http://thomasklaiber.com/
 * Plugin URI: http://thomasklaiber.com/bbpress/post-notification/
 * Version: 1.4.x
 */

function notification_new_post($post_id=0) {
  global $bbdb, $bb_table_prefix, $topic_id, $bb_current_user;

  $all_users = notification_select_all_users();
  foreach ($all_users as $userdata) :
    if ( notification_is_activated( $userdata->ID ) && $userdata->ID != $bb_current_user->ID) :
      if (notification_all_is_activated( $userdata->ID ) || is_user_favorite( $userdata->ID, $topic_id ) ) :
        $message = __("There is a new post on:\n %1\$s \n\nReply by:\n %2\$s \n\nText:\n %3\$s \n\n%4\$s ");
          mail_utf8( $userdata->user_email, bb_get_option('name') . ': ' . get_topic_title($topic_id), sprintf( $message, get_topic_title($topic_id), get_user_name($bb_current_user->ID), strip_tags(get_post_text($post_id)), get_topic_link($topic_id) ), 'From: '.get_user_name($bb_current_user->ID).' <'.bb_get_option('from_email').'>'
          );
      endif;
    endif;
  endforeach;
}
add_action('bb_new_post', 'notification_new_post');

function mail_utf8($to, $subject = '(No subject)', $message = '', $header = '') {
  $header_ = 'MIME-Version: 1.0' . "\r\n" . 'Content-type: text/plain; charset=UTF-8' . "\r\n";
  mail($to, '=?UTF-8?B?'.base64_encode($subject).'?=', $message, $header_ . $header);
} 

function notification_select_all_users() {
  global $bbdb;

  $all_users = $bbdb->get_results("SELECT ID, user_email FROM $bbdb->users WHERE user_status=0");

  return $all_users;
}

function notification_profile() {
  global $user_id, $bb_current_user;

  if ( bb_is_user_logged_in() ) :

    $checked = "";
    if (notification_is_activated($user_id)) :
      $checked = "checked='checked'";
    endif;

    $checked_all_on = "";
    $checked_all_off = "checked='checked'";
    if (notification_all_is_activated($user_id)) :
      $checked_all_on = "checked='checked'";
      $checked_all_off = "";
    endif;

    echo "<fieldset>
<legend>Favorite Notification</legend>
<p> " . __('Email me when there'."'".'s a new post in a topic.') . "</p>
<table width=\"100%\">
<tr>
<th width=\"21%\" scope=\"row\">" . __("Activate Notification") . ":</th>
<td width=\"79%\" ><input name=\"favorite_notification\" id=\"favorite_notification\" type=\"checkbox\" value=\"1\"" . $checked . " /></td>
</tr>
</table>
<p> " . __('When should the system send an email?') . "</p>
<table width=\"100%\">
<tr>
<th width=\"21%\" scope=\"row\">" . __("Only favorites") . ":</th>
<td width=\"79%\" >
<input name=\"favorite_notification_all\" id=\"favorite_notification_all\" type=\"radio\" value=\"0\"" . $checked_all_off . " /></td>
</tr>
<tr>
<th width=\"21%\" scope=\"row\">" . __("All topics") . ":</th>
<td width=\"79%\" >
<input name=\"favorite_notification_all\" id=\"favorite_notification_all\" type=\"radio\" value=\"1\"" . $checked_all_on . " /></td>
</tr>
</table>
</fieldset>\n\n";
  endif;
}
add_action('extra_profile_info', 'notification_profile');

function notification_profile_edit() {
  global $user_id;

  bb_update_usermeta($user_id, "favorite_notification", $_POST['favorite_notification']);
  bb_update_usermeta($user_id, "favorite_notification_all", $_POST['favorite_notification_all']);
}
add_action('profile_edited', 'notification_profile_edit');

function notification_is_activated($user_id) {
  $user = bb_get_user( $user_id );
  if ($user->favorite_notification) :
    return true;
  else :
    return false;
  endif;
}

function notification_all_is_activated($user_id) {
  $user = bb_get_user( $user_id );
  if ($user->favorite_notification_all) :
    return true;
  else :
    return false;
  endif;
}
?>