bbPress

Info

• 19 posts
• 7 voices
• Started 3 years ago by travelsuperlink
• Latest reply from John James Jacoby
• This topic is not resolved

Tags

• tag error
• tag remove fail
• tags

• Posts in this topic

tag remove fail

1. • 
   • travelsuperlink
   • Member

   • Posted 3 years ago #

   Just upgrade from bbpress 0.8 to bbPress 1.0-alpha-2 released.
   database upgrade is successful. however, found an issue about tag removal.

   user can add tags, however, as an admin, if I want to remove tags, it forward to a webpage:

   like:
   http://www.travelsuperlink.com/forum/tag-remove.php?tag=387&user=20350&_wpnonce=15badfc986

   error message is:
   Your attempt to remove this tag from this topic has failed.
   Please try again.

   I searched in the forum and found one similar post, but no answer yet. any idea? thanks.
2. • 
   • _ck_
   • Moderator

   • Posted 3 years ago #

   Please file this in http://trac.bbpress.org
   so Sam will see it and address it.

   But it's possible that it's been fixed already in the trunk.
3. • 
   • ganzua
   • Member

   • Posted 3 years ago #

   I think it is not fixed. I have the same problem with 1.06a.
4. • 
   • Tom(dB)
   • Member

   • Posted 3 years ago #

   having same problems here on 1 alpha 6. Would love to see this fixed asap. No pressure or anything! ;) Thanks.
5. • 
   • Sam Bauers
   • Key Master

   • Posted 3 years ago #

   This was the non-ajax method only. Fixed in trunk.
6. • 
   • ganzua
   • Member

   • Posted 3 years ago #

   Thanks for the fix :)

   I have functions.bb-template.php and functions.bb-core.php modified because there are some stuff that is related with the template; h2 tag, tag cloud size, « Previous and a &hellip for pagination...

   Could it be possible to move this stuff to the template folder? perhaps in a functions.php file?
7. • 
   • ganzua
   • Member

   • Posted 3 years ago #

   BTW, I just tried to remove a tag and it says that I can't because the topic "is closed" when it actually is not :s
8. • 
   • Tom(dB)
   • Member

   • Posted 3 years ago #

   wow, that was quick. Could you let me know which file(s) it is that have changed so I can upload the relevant ones rather than the whole lot?
9. • 
   • ganzua
   • Member

   • Posted 3 years ago #

   it is functions.bb-template.php but it didn't work for me
10. • 
    • Tom(dB)
    • Member

    • Posted 3 years ago #

    just discovered subversion, wow!

    anyway, it's not working. I get "The tag was not removed. You cannot remove a tag from a closed topic." despite the topic not being closed.

    edit:
    and now "Your attempt to remove this tag from this topic has failed. Please try again."
11. • 
    • Tom(dB)
    • Member

    • Posted 3 years ago #

    the 'destroy tag' option that you get on the bottom of the tag's page does delete the tags, though it reports '0 records deleted' on the page after they're deleted.

    the plot thickens...
12. • 
    • Sam Bauers
    • Key Master

    • Posted 3 years ago #

    I'll take another look at this.

    @ganzua

    I don't quite understand your question. If you utilise the API properly there is no need to modify core files. You can place modifications in a plugin or in a functions.php file in your theme.
13. • 
    • ganzua
    • Member

    • Posted 3 years ago #

    You can place modifications in a plugin or in a functions.php file in your theme.

    I have no idea about how to do this but if somebody put me on the trail I'm pretty sure I'll manage. How can I replace some functions from functions.bb-template.php and functions.bb-core.php with a plugin?
14. • 
    • Ipstenu
    • Member

    • Posted 3 years ago #

    Create functions.php in your theme folder.

    Then ... well, you use remove and add :) Example:

    // This sets closed lable to read as 'read only' instead of 'closed'
    remove_filter('bb_topic_labels', 'bb_closed_label');
    function my_closed_label( $label ) {
            global $topic;
            if ( '0' === $topic->topic_open )
                    return sprintf(__('[Read Only] %s'), $label);
            return $label;
    }
    add_filter('bb_topic_labels', 'my_closed_label');
15. • 
    • ganzua
    • Member

    • Posted 3 years ago #

    Thanks Ipstenu :)

    I do not catch the first line; remove_filter('bb_topic_labels', 'bb_closed_label');

    bb_closed_label is the function that you are going to replace, but what is bb_topic_labels and where do you get it?

    I want to replace post_form, bb_tag_heat_map and bb_paginate_links functions
16. • 
    • Tom(dB)
    • Member

    • Posted 3 years ago #

    Update:
    the little x next to tags does delete them in an ajax style. The problem was after updating from 0.9 to 1.0 I did not update my themes properly.

    topic_tags(); now covers the whole thing - taking the add tag form from line 2457 on functions.bb-template.php
17. • 
    • ganzua
    • Member

    • Posted 3 years ago #

    I don't get it. I'm using topic_tags and [X] won't delete any tag.
18. • 
    • Tom(dB)
    • Member

    • Posted 3 years ago #

    @ganzua, are you using v1.06a?
19. • 
    • John James Jacoby
    • Key Master

    • Posted 3 years ago #

    @ganzua: I predict that you are integrated with WordPress, and that your jQuery isn't being loaded correctly.

    I will prove this theory by asking for you to add a topic to your favorites on your forum, and report back and let me know if it works. :)

20. You must log in to post.