Skip to:
Content
Pages
Categories
Search
Top
Bottom

Search – Relevant Post Links Broken

Viewing 22 replies - 1 through 22 (of 22 total)
  • they are returning links like the following:

    http://www.pagelines.com/forum/topic.php#post-

    (no post number on the end)

    Has anybody else seen this one?


    chrishajer
    Participant

    @chrishajer

    I’ve seen it here and also experienced it at Justin Tadlock’s Theme Hybrid forums.

    I don’t rely on bbPress built in search too much since it’s so bad. I just use google site:bbpress.org/forums whatever to search. That doesn’t mean they shouldn’t fix it, but it does not appear to be the only thing wrong with bbPress search.

    There was recent discussion of the quality of bbPress plugin search too:

    http://bbpress.org/forums/topic/is-it-just-me-or-does-the-plugin-search-suck


    johnhiler
    Member

    @johnhiler

    It sounds like an issue with the search.php file in your template. You may be using a template from 0.9 that isn’t compatible with bbPress version 1.0 (or vice versa).

    Try either deleting it, or replacing it with the standard template from Kakumei:

    http://svn.automattic.com/bbpress/trunk/bb-templates/kakumei/search.php


    chrishajer
    Participant

    @chrishajer

    johnhiler, why do you suspect it doesn’t work here? Try this search:

    http://bbpress.org/forums/search.php?q=i18n

    Check the Relevant Posts results. Some of the links are incomplete, results 1, 4, 7, 8, 9 when I searched. Not all are broken, just some.


    johnhiler
    Member

    @johnhiler

    Oh you’re right… sorry I hadn’t noticed that before. I haven’t had problems with the search before myself (it could be b/c I’m still using the 0.9 branch).

    Here’s a sample search that works OK for me?

    http://boards.weddingbee.com/search.php?q=weddings

    I’d be curious if there was still an issue once the search.php file was deleted or updated… if so, then it could definitely be a broader issue!


    chrishajer
    Participant

    @chrishajer

    (it could be b/c I’m still using the 0.9 branch)

    I think it’s a problem with 1.0. I’ve never had a problem in the one 0.9 installation I have, but I do see it all over with 1.0 installations.


    chrishajer
    Participant

    @chrishajer

    I have one 1.0-alpha-2 installation where it does not happen. Maybe the error was introduced after that?

    So this may be an issue with the BBP core?

    Should I file a ticket?


    johnhiler
    Member

    @johnhiler

    I have a test install using version 1.0, and search result links seem OK on there.

    Could you try deleting your search.php file (back it up first!) and making sure your kakumei under /bb-templates/ is using the latest version? If that doesn’t work, then definitely file a ticket…


    chrishajer
    Participant

    @chrishajer

    Agreed – file a ticket.

    It’s also pretty clear the problem does not always occur (some links are OK, some are broken) so the problem is dependent on some other factor, maybe something specific about the actual replies that are in the results.

    Tried to file a ticket; but didn’t know how to create an account.,

    Any tips?


    chrishajer
    Participant

    @chrishajer

    If you have an account at wordpress.org forums, you can log in with those details at trac.bbpress.org. I’m not sure how else to create an account that will work there.

    I found a way to reproduce the error and replied to the ticket: http://trac.bbpress.org/ticket/1222#comment:2

    Could someone check to see whether they can also recreate this issue?


    gerikg
    Member

    @gerikg

    I’m using this as an example: http://bbpress.org/forums/search.php?q=i18n

    Did you noticed that the if the same topic shows up in

    Search for “i18n” Recent Posts = Relevant posts

    then it’s broken? If you see the broken one Recent post #2 and Revelant Post #4 have the same title. I don’t know if that helps.


    chrishajer
    Participant

    @chrishajer

    gerikg, I just committed the patch to fix this. I believe bbpress.org is running trunk and it updates on some sort of schedule/cron, so that fix will be present here tomorrow probably. Could you test again tomorrow?

    I don’t know when or how the code gets updated here, but I am seeing my changes here a day or two after committing to trac.

    Thanks


    gerikg
    Member

    @gerikg

    It looks fixed, thank you! I’ll put the link below but not complete the link because it will add this post into the search for

    “bbpress 1.03″

    What’s next?


    chrishajer
    Participant

    @chrishajer

    Umm, the code is committed so it will be in the next release. It’s in the trunk version now, but I don’t recommend running that on a production site.


    gerikg
    Member

    @gerikg

    Wow I feel stupid.

    I have the same problem right now with bbPress 1.0.3. If you’re interested, you can put this piece of code before the “if ( $relevant ) ” line:

    <?php
    foreach ( $relevant as $elementKey => $bb_post ) {
    if(!($bb_post->post_text)) unset($relevant[$elementKey]);
    }
    ?>

    This deletes the relevant posts which are already in the recent posts, and so are broken.

Viewing 22 replies - 1 through 22 (of 22 total)

You must be logged in to reply to this topic.