bbPress

Info

• 3 posts
• 2 voices
• Started 1 year ago by ewimberley
• Latest reply from ewimberley

Tags

• bb_get_forum_dropdown
• functions.bb-template.php
• trac

• Posts in this topic

Malformed html created by bb_get_forum_dropdown.

1. • 
   • ewimberley
   • Member

   • Posted 1 year ago #

   When generating a dropdown menu, bb_get_forum_dropdown (from bb-includes/functions.bb-template.php) adds an extra quotation mark inside the select tag like this:
   <select name="forum_id" id="forum-id"">

   When it should be like this:
   <select name="forum_id" id="forum-id">

   The offending line is right here:
   $r .= '<select name="' . $name . '" id="' . $id . '"' . $tab . '">' . "\n";

   To fix this, change it to:
   $r .= '<select name="' . $name . '" id="' . $id . '"' . $tab . '>' . "\n";
2. • 
   • chrishajer
   • Moderator

   • Posted 1 year ago #

   Good catch. I opened trac ticket http://trac.bbpress.org/ticket/1256
3. • 
   • ewimberley
   • Member

   • Posted 1 year ago #

   Thanks, an HTML parser caught it for me though.
4. This topic is closed