http://bbpress.org/forums/ bbPress support forums Topic: Proposed method for file attachments and uploads en Sat, 06 Sep 2008 06:35:35 +0000 http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads/page/2#post-15612 Mon, 21 Apr 2008 13:52:44 +0000 _ck_ 15612@http://bbpress.org/forums/ <p>I agree with not doing the actions in the templates - that was a mistake WordPress did for awhile eh? The hooks can go inside <code>function edit_form</code> in the core, no?</p> <p>Just for clarification, because this one is important, <code>do_action(&#39;post_edit_form&#39;)</code> should go AFTER the <code>&lt;/form&gt;</code> is closed. </p> <p><code>do_action(&#39;pre_edit_form&#39;)</code> should be before the <code>&lt;form</code><br /> and <code>do_action(&#39;edit_form&#39;)</code> should be inside the form.</p> <p>If all the post_form's are actions, so should be the edit_forms. I don't think any are filters, wouldn't make sense...?</p> <p>This will help other plugins like my Signatures too.<br /> Less template edits needed, makes it easier for users.</p> <p>Of course I still have to support some 0.8.3 people so it's going to be awhile before this solves all problems but at least newer installs can benefit. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads/page/2#post-15599 Mon, 21 Apr 2008 12:07:59 +0000 sambauers 15599@http://bbpress.org/forums/ <p>I recall a ticket where mdawaffe was hesitant to put hooks in the templates.</p> <p>Would you require hooks in the templates? </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads/page/2#post-15591 Mon, 21 Apr 2008 08:30:02 +0000 _ck_ 15591@http://bbpress.org/forums/ <p>The ticket was months back, I'd have to search.<br /> It's fairly simple in theory though, why not mimic the existing hook structure for new posts to match editing existing posts:<br /> <code>pre_post_form</code> -&gt; <code>pre_edit_form</code><br /> <code>post_form</code> -&gt; <code>edit_form</code><br /> <code>post_post_form</code> -&gt; <code>post_edit_form</code> </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads/page/2#post-15581 Sun, 20 Apr 2008 23:29:13 +0000 sambauers 15581@http://bbpress.org/forums/ <p>@ _ck_</p> <p>Which ticket was he hook request in. I'll see if I can do something about it sooner rather than later.</p> <p>I'm also happy to do a new release 0.9.0.2 to get those changes more readily available for this plugin. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads/page/2#post-15560 Sun, 20 Apr 2008 09:16:24 +0000 _ck_ 15560@http://bbpress.org/forums/ <p>An early beta is now available for review:<br /> <a href="http://bbpress.org/plugins/topic/bb-attachments/" rel="nofollow">http://bbpress.org/plugins/topic/bb-attachments/</a> </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads/page/2#post-15550 Sat, 19 Apr 2008 20:08:40 +0000 _ck_ 15550@http://bbpress.org/forums/ <p><em>fel64: No, there's been hooks for the post form for as long as I can remember.</em></p> <p>Unfortunately that's only for new posts. For editing existing posts there is absolutely no way to affect the template without editing it. There's no hooks for edit_form() or any of it's sub-functions or the template loader (the loader does the include AFTER the hook so nothing can be placed afterwards. I requested some hooks many month ago but they may have been missed (or ignored). This plugin will require (one, simple) edit of the <code>edit-post.php</code> template.</p> <p>(In theory it could be done via the bb_get_footer but that's really messy and the footer hook is AFTER the footer has been rendered). </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads/page/2#post-15548 Sat, 19 Apr 2008 14:37:36 +0000 _ck_ 15548@http://bbpress.org/forums/ <p>Yes there used to be a limit with readfile/passthru but supposedly fixed in newer PHP and even the old limit was 2mb which is fairly high anyway. Also there is some debate that flushing output and making sure compression/output buffers are turned off avoids the limit. We'll find out as more people test it.</p> <p>I'll have a version up for testing in 12 hours or so. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15547 Sat, 19 Apr 2008 13:13:37 +0000 sambauers 15547@http://bbpress.org/forums/ <p>Oh, and the file size may be limited by the memory limits in PHP that way too. Not the file upload size limits, but the memory allocation limits set in the PHP INI file.</p> <p>This stuff will come out in the wash once it is released and in the hands of users though. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15545 Sat, 19 Apr 2008 13:10:47 +0000 sambauers 15545@http://bbpress.org/forums/ <p>Piping things through PHP will be slower (but potentially more secure). </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15539 Sat, 19 Apr 2008 07:44:55 +0000 _ck_ 15539@http://bbpress.org/forums/ <p>Progress is excellent, way ahead of schedule, should have a public demo Saturday night (24 hours or so).</p> <p>Working on a auto-thumbnail method now for image uploads.</p> <p>I've come up with some extra security features like the files are not directly publicly accessible (stored in non-webroot directory) so they never get fed through the parsers and cannot be executed (ie. .php .html .asp) even if someone manages to trick a file extension or mime somehow. The only downside to this is that the files must be "dumped" through PHP (readfile) which will keep the PHP session open longer but unless you are serving multi-megabyte files at high traffic rates, this should not be a big issue (optionally you can make the files directly accessible off the web if this is critical issue). </p> <p>As a bonus the above method makes hotlinking impossible as you can set attachments as accessible to logged-in members only. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15535 Sat, 19 Apr 2008 05:46:45 +0000 sambauers 15535@http://bbpress.org/forums/ <p>@ _ck_</p> <p>I think all languages place the file extension on the right of the filename. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15530 Sat, 19 Apr 2008 02:11:36 +0000 Beer 15530@http://bbpress.org/forums/ <p>I'm glad the donation idea is working. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15525 Fri, 18 Apr 2008 21:56:38 +0000 HowToGeek 15525@http://bbpress.org/forums/ <p>I donated towards this plugin as well. Very happy to see this being worked on!</p> <p>@Everybody: You can donate directly to _ck_ with this link:</p> <p><a href="http://amazon.com/paypage/P2FBORKDEFQIVM" rel="nofollow">http://amazon.com/paypage/P2FBORKDEFQIVM</a> </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15521 Fri, 18 Apr 2008 19:21:19 +0000 _ck_ 15521@http://bbpress.org/forums/ <p>Very early sneak preview:<br /> <a href="http://img156.imageshack.us/img156/8615/bbattachmentspreviewpv0.png" rel="nofollow">http://img156.imageshack.us/img156/8615/bbattachmentspreviewpv0.png</a> </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15515 Fri, 18 Apr 2008 17:05:26 +0000 gregory.dziedzic 15515@http://bbpress.org/forums/ <p>_ck_ you are wonderful :) </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15512 Fri, 18 Apr 2008 16:10:58 +0000 _ck_ 15512@http://bbpress.org/forums/ <p>I've got a skeleton prototype working already but I have an important question:</p> <p>In Right-To-Left languages, filenames are still left-to-right, correct? ie. it's never gif.filename, always filename.gif ?</p> <p>Sounds silly but you never know... I mean how does Chinese or Japanese handle filenames? </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15511 Fri, 18 Apr 2008 14:33:04 +0000 sambauers 15511@http://bbpress.org/forums/ <p>It was USD$50</p> <p>:)</p> <p>I say just get it up to a usable state and out the door. Then we can all work on making it better over time. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15510 Fri, 18 Apr 2008 10:46:37 +0000 _ck_ 15510@http://bbpress.org/forums/ <p>Whoa, $50 AUS? That's like half a million US $ right now! I could buy 3, maybe even 4 gallons of gas (if I owned a car) LOL! :D</p> <p>Seriously though, many thanks, that's a massive donation. Now I feel guilty like I have to make this an amazing plugin. Hope I can live up to it. I should have an early alpha for review Sunday or Monday night... </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15504 Fri, 18 Apr 2008 09:43:38 +0000 sambauers 15504@http://bbpress.org/forums/ <p><a href="http://bbpress.org/forums/topic/priority-1-imagefile-attachments#post-15503">I'm putting my money where my mouth is</a>, and donated $50 to _ck_ towards the development of this plugin.</p> <p>Thanks for starting this _ck_, it will be a welcome plugin addition. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15502 Fri, 18 Apr 2008 07:58:35 +0000 _ck_ 15502@http://bbpress.org/forums/ <p>Alright, I'll start working on this.<br /> It won't be feature rich at start but I'll give you some basic functionality in a few days. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15491 Thu, 17 Apr 2008 20:52:57 +0000 Beer 15491@http://bbpress.org/forums/ <p>We could try to appeal to the mercy of whoever the current plug-in coders are. I've seen something at TextDrive where a group would donate some money into a pool for development purposes.</p> <p>I think it'd be great if they added the "Ideas" feature here at bbPress like they have for Wordpress also.<br /> <a href="http://wordpress.org/extend/ideas/" rel="nofollow">http://wordpress.org/extend/ideas/</a> </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15487 Thu, 17 Apr 2008 19:14:18 +0000 gregory.dziedzic 15487@http://bbpress.org/forums/ <p>Ok for a plug-in yeah.... </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15287 Fri, 11 Apr 2008 21:26:58 +0000 joeyv 15287@http://bbpress.org/forums/ <p>I would be in favor of an attachment plug-in </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15165 Tue, 08 Apr 2008 20:16:50 +0000 chrishajer 15165@http://bbpress.org/forums/ <p>I don't want this functionality included in bbPress. Do it with a plugin. Keep bbPress lean. That's my vote. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-15160 Tue, 08 Apr 2008 18:37:52 +0000 bensig 15160@http://bbpress.org/forums/ <p>bbPress seems to be the ONLY forum software that I've been testing which does not have this feature.</p> <p>In fact, the ability to attach items to forum posts (as well as the administrative authority to limit the size of these attachments) seems critical to almost any forum - especially ones that I have setup for clients. </p> <p>I would consider this more important than an avatar. It should be a high priority on the development list for the forum - a feature, not a plug-in.</p> <p>From what I've seen, yetanotherforum.net handles attachments very well - but I prefer the look of bbpress.</p> <p>Let's put the pressure on bbpress dev teams...</p> <p>Anyone else have good experiences with a forum that allows image attachments? </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-13720 Mon, 11 Feb 2008 18:18:21 +0000 charliestout 13720@http://bbpress.org/forums/ <p>Sam, this is great news. I'm not a coder but I'm fairly good with CSS. I could help with writing classes for some of the more popular themes. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-13675 Sat, 09 Feb 2008 00:22:21 +0000 sambauers 13675@http://bbpress.org/forums/ <p>We almost certainly won't write this into core, but if someone wants to write this and they are missing the necessary filters/actions in core to do it we can easily add those for them. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-13674 Fri, 08 Feb 2008 23:14:31 +0000 charliestout 13674@http://bbpress.org/forums/ <p>Fel64, you are totally right. That wasn't so much an appeal to inferiority as it was an appeal to the bandwagon: I simply think people tend to judge a product based on what's included, moreso than what's excluded. I could have worded that better.</p> <p>I could try to make a better case for an attachments plugin, but I run the risk of becoming "that crazy dude who's always whining about attachments." Besides, I don't feel like I should try to argue the point, because I don't really hear anyone arguing *against* it.</p> <p>The best case I can see for any plugin is a chorus of users singing the same tune, asking for such an extension and offering what resources they have to contribute to it. I appreciate the input from everyone on this discussion, and hope we can continue it to the eventual development of this feature. As I mentioned before, I will look at the code, and do what I can (hack around) but then I'll run the risk of being "that crazy dude who thought he could write a file attachment plugin."</p> <p>Which might be slightly better than being the dude who was just whining about not having one. But still. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-13671 Fri, 08 Feb 2008 22:00:25 +0000 fel64 13671@http://bbpress.org/forums/ <p><em>(which if I remember from my signatures plugin has no action hook unfortunately and templates will need to be edited)</em></p> <p>No, there's been hooks for the post form for as long as I can remember.</p> <ul> <li><code>pre_post_form</code></li> <li><code>post_form</code></li> <li><code>post_post_form</code></li> </ul> <p>Charlie: ticking off boxes because other software ticks those boxes is feature creep. Goes against, as you say, what bbpress is about. And even if it didn't, it makes no sense; feature ideas should be evaluated on their own merits. I'm not saying attachments shouldn't make it in (personally, I don't much like file attachments), but that you can make a much much better case for it than saying that it's a square on the Forum Matrix that bbpress doesn't have. </p> http://bbpress.org/forums/topic/proposed-method-for-file-attachments-and-uploads#post-13670 Fri, 08 Feb 2008 21:51:01 +0000 charliestout 13670@http://bbpress.org/forums/ <p>I can't speak for the world at large, but I think that many people might be passing up a great product (bbpress) because they are looking for forum software with a few more "essential" features. A great number of other forum packages on the ForumMatrix offer multiple file attachments, and while I agree with the developer's dream of keeping this thing nice and lite and agile, I think anytime a red X on the ForumMatrix is eliminated, it increases the overall appeal of bbpress to the forum dev community.</p> <p>HowToGeek, I don't know how much use I'd be to you as a coder, but I'm willing to do whatever I can to help you start a plugin like this. </p>