http://bbpress.org/forums/ bbPress Support Forums Tag: kses en Fri, 09 Jan 2009 03:58:46 +0000 http://bbpress.org/forums/topic/wp-integration-slashes-the-root-of-all-evil#post-4918 Mon, 26 Feb 2007 19:35:27 +0000 pashka80 4918@http://bbpress.org/forums/ <p>jmmhm </p> http://bbpress.org/forums/topic/wp-integration-slashes-the-root-of-all-evil#post-4000 Sun, 04 Feb 2007 23:20:02 +0000 baptiste 4000@http://bbpress.org/forums/ <p>Yes. I figured that's what it was called - I just couldn't find it referenced in the source anywhere. I must have grepped badly. Will try that out. </p> http://bbpress.org/forums/topic/wp-integration-slashes-the-root-of-all-evil#post-3998 Sun, 04 Feb 2007 21:57:08 +0000 thomasklaiber 3998@http://bbpress.org/forums/ <p>In bbpress it is called 'bb_init' ... do you mean this? </p> http://bbpress.org/forums/topic/wp-integration-slashes-the-root-of-all-evil#post-3997 Sun, 04 Feb 2007 21:38:40 +0000 baptiste 3997@http://bbpress.org/forums/ <p>I brain locked. bb_head is probably too late for this. Is there an equivalent of the 'init' hook for bbPress? In WordPress, that filter hook gets run after the environment initializes. That's when the code I included would need to be run. I can't seem to find an applicable filter hook called that early. </p> http://bbpress.org/forums/topic/wp-integration-slashes-the-root-of-all-evil#post-3995 Sun, 04 Feb 2007 17:53:20 +0000 baptiste 3995@http://bbpress.org/forums/ <p>Would the solution be to execute a stripslashes_deep on GET, POST, etc if WP_BB is true? Seems kinda dangerous - but bbpress doesn't expect this in a non-integrated environment, so undoing what wp-settings.php does (which gets run when you include wp-config to get the WordPress API) seems harmless enough.</p> <p>Maybe something along the lines of:</p> <p><code>function bb_undo_wp_slashes() {<br /> $_GET = stripslashes_deep($_GET );<br /> $_POST = stripslashes_deep($_POST );<br /> $_COOKIE = stripslashes_deep($_COOKIE);<br /> $_SERVER = stripslashes_deep($_SERVER);<br /> }</code></p> <p>and call that as a filter for bb_head?</p> <p><code>if (defined(&#39;WP_BB&#39;) &#38;&amp; WP_BB) add_action(&#39;bb_head&#39;, &#39;bb_undo_wp_slashes&#39;);</code></p> <p>I think bb_head is called after the environment is setup.</p> <p>I may give this a try. Thoughts from developers who know more about bbPress than I? </p> http://bbpress.org/forums/topic/wp-integration-slashes-the-root-of-all-evil#post-3994 Sun, 04 Feb 2007 17:41:17 +0000 baptiste 3994@http://bbpress.org/forums/ <p>Weird. I have magic quotes off. However, I notice that wp-settings adds slashes to EVERY request in wp-settings:</p> <p><code>// If already slashed, strip.<br /> if ( get_magic_quotes_gpc() ) {<br /> $_GET = stripslashes_deep($_GET );<br /> $_POST = stripslashes_deep($_POST );<br /> $_COOKIE = stripslashes_deep($_COOKIE);<br /> }</code></p> <p><code>// Escape with wpdb.<br /> $_GET = add_magic_quotes($_GET );<br /> $_POST = add_magic_quotes($_POST );<br /> $_COOKIE = add_magic_quotes($_COOKIE);<br /> $_SERVER = add_magic_quotes($_SERVER);<br /> </code></p> <p>Is bbpress not expecting this? This might explain the double slashing even if magic quotes is off (I checked my php.ini - it is off) </p> http://bbpress.org/forums/topic/wp-integration-slashes-the-root-of-all-evil#post-3993 Sun, 04 Feb 2007 17:34:35 +0000 baptiste 3993@http://bbpress.org/forums/ <p>So I've been digging further into the strange behavior I've had with slashes in posts AND with HTML tag attributes being yanked out.</p> <p>It's all related. Apparently, there is some type of problem where slashes get added TWICE when the WP intergation is on. This is why slashes start showing up everywhere and why kses fails.</p> <p>I finally discovered that even though the stripslashes filter is called before bb_filter_kses, there are still slashes in front of the quotes of the attributes. So they get tossed.</p> <p>So I took out all the stripslashes hacks I had put into the title and post routines and called stripslashes TWICE as a pre_post filter. Voila - attributes are preserved. </p> <p><code>add_filter('pre_post', 'stripslashes', 40);<br /> add_filter('pre_post', 'stripslashes', 45); // 2nd Time</code></p> <p>I also added this little section in default-filters.php:</p> <p><code>// Slash problems when integrated with WordPress<br /> if (defined('WP_BB') &#38;&amp; WP_BB) {<br /> add_filter('post_text', 'stripslashes');<br /> add_filter('get_topic_title', 'stripslashes');<br /> add_filter('get_bb_title', 'stripslashes');<br /> add_filter('edit_text', 'stripslashes');<br /> }</code></p> <p>And it stripped out the slashes in titles, browser bars, posts, edit screens, etc. (Note there is a missing semi-colon after the sort_tag_heat_map line - you need to add on if you put this at the end)</p> <p>This is still a hack. I don't have magic quotes on. I still need to dig and find out why there seems to be alternate behavior when wordpress is integrated or not. Maybe WordPress is turning on magic quotes and bbPress doesn't expect it to be on?</p> <p>Still digging. </p> http://bbpress.org/forums/topic/bbpresswordpress-integration-there-are-problems#post-3879 Wed, 31 Jan 2007 13:08:02 +0000 baptiste 3879@http://bbpress.org/forums/ <p>This is bizarre. If bbPress integrated is using the WordPress version of kses, you'd think the same problem with href disappearing would happen in WordPress too, but it doesn't. I'm still digging, but this is really puzzling.</p> <p>I have confirmed, however, that ALL attributes are being stripped that should be allowed. href, rel, cite in blockquote, etc. </p> http://bbpress.org/forums/topic/bbpresswordpress-integration-there-are-problems#post-3878 Wed, 31 Jan 2007 12:38:57 +0000 baptiste 3878@http://bbpress.org/forums/ <p>All,</p> <p>I've posted a few things on the forums about odd behavior I've seen - href attributes in a tags getting stripped, slashes not getting stripped, etc.</p> <p>I've confirmed that these problems are due to the WordPress integration. I am running WordPress 2.1 and bbPress 0.75 and followed the documentation to do the integration.</p> <p>When I stop loading wp-config in my bbPress config, the slashes get removed and href attributes stay in posts.</p> <p>I'm still digging, but part of this problem is overlap between WordPress and bbPress. The docs talk about a constant WP_BB that tells the code there are possibly conflicting APIs out there. Setting it causes bbPress to use the kses code from WordPress instead. WordPress 2.1 uses kses v0.2.2 while bbPress ships with v0.2.1. My guess is something changed between the two that bbPress doesn't handle.</p> <p>As for the slashes in front of apostrophes, it MAY be part of it - I'm not sure yet if kses is used to strip slashes. I didn't think kses got called except during posting, not during viewing. There is another library from WordPress that bbPress uses in integration mode (l10n) for localization - not sure if this is involved in anyway (doubt it)</p> <p>So if you're seeing weird behavior - it may very well be intergation. But the good news is it doesn't seem to be overly difficult to fix. Still digging to find the 'right' way (though as a hack for the slash problem, you can include a stripslashes call in template-functions:</p> <p><code>function get_post_text() {<br /> global $bb_post;<br /> // Hack to strip slashes until Wordpress integration is fixed<br /> return stripslashes($bb_post-&gt;post_text);<br /> }</code></p> <p>Anyway - just an FYI. I'll dig more into the kses href issue and post if I find anything. </p>