And I do have a few favorites selected, FYI

It just shows that the user has no favorites.

Any help would be greatly appreciated!

Please err on the side of over explanation.

Thanks!

1. Create Forum
2. Create Topic
3. View Topic in WordPress
4. Click 'Add this topic to your favorites'
a) Clicking the [x] next to the 'This topic is one of your favorites' seems to redirect correctly.
5. Click the 'favorites' link
6. You are now in the 'forums/users/[username]'; scroll down to the 'Favorite Forum Topics'
7. Click the "x" button to remove. I am redirected back to '2011/08/04/hello-world/' for example. My expected action would to have been redirected to the /forums/users/[username] as that is where I was.

It could be I don't have something configure correctly but this is an out of the box installation.

I looked at the bbp_favorites_handler() in ./bbpress/bbp-includes/bbp_user_functions.php and the fall back action for the redirect is get_permalink(). This should be something more like $_SERVER['HTTP_REFERER'] to redirect the user back to their original page.

For the most part, I have not yet gotten into looking for bugs as I am 100% focused on building a custom template. For now I am not going crazy until things are more stable. It is a tedious job recreating the theme templates on each revision, which means I am leaving the internal logic alone for now.

Once I have a better grasp of what is truly going on, then I'll post more reports. These reports are just the basic stuff that I am coming across while picturing what I want my bbpress to function like.

No, I have not setup any forums as private or hidden yet, have not yet made it that far into bbpress.

Is it possible the reason why they're appearing for you when you're logged in, and not for other users (or logged out users) because those topics exist inside a private or hidden forum?

I did find a possible undefined variable situation that could cause an error value to be returned instead of topic ID's, so if the topics exist in public forums, that code change might fix it.

It is when I am not logged in that my user.php profile page says
'This user has no favorite topics.'

Now either the logic is broken, or it is intentional not to show a users favorites to a non-logged-in user. If that is the case then we need the logic to remove the favorites from non-logged-in users.

IMHO, I don't think the public has any business knowing which posts are my favorites. I'd rather just have that text taken out of the template if I am viewing any users profile other than my own.

add to your style.css
#favorite-toggle{display:none;}

The three tabs will still show up but the option to add to favorites option won't show up on the posts.

open profile.php
line #25 that starts with
<?php if (bb_current_user_can( 'edit_favorites_of', $user->ID )) : ?>
add BEFORE
<!--

line #27
<?php endif; ?>
add AFTER
-->

I don't know how to edit the three tabs.. sorry

maybe by some css coding display:none?

But you should be able to remove it just by removing the favorite links from the template! This is the key template file, I believe:
http://svn.automattic.com/bbpress/trunk/bb-templates/kakumei/topic.php

First Last (usersemail@domain.com) favorites

So since the "Favorites" function is not very popular on our site, I thought we could simply deactivate that functionality, rather than having to write a bunch of code to hide the email address from this page.

Anyone?

Please, be less specific, don't post any code, oooh and don't include a screenshot. Guessing is a really worth while use of my time :)