http://bbpress.org/forums/ bbPress Support Forums User Favorites: Guru06 en Thu, 08 Jan 2009 12:54:10 +0000 http://bbpress.org/forums/topic/open-links-in-new-window#post-20625 Tue, 11 Nov 2008 20:14:18 +0000 TrishaM 20625@http://bbpress.org/forums/ <p>Thanks _ck_ - I'll do as suggested.......</p> <p>P.S. At cafepress.com you can design your own bumper sticker! I've made a few of my own t-shirts that way.....perfect for when you know just what you want but can't find it anywhere.... :) </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-20624 Tue, 11 Nov 2008 20:01:35 +0000 lstelie 20624@http://bbpress.org/forums/ <p><em>People who insist on perfect validation need to find more productive things to do with their time, there's alot of code out there that needs to be written! ;-)</em></p> <p>Good point :) </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-20622 Tue, 11 Nov 2008 19:33:47 +0000 _ck_ 20622@http://bbpress.org/forums/ <p>TrishaM, if you are using bb-tweaks.php you can just add the above code to the bottom of it and disable the target_blank filter. But it will work either way.</p> <p>lstelie, there is another problem with using javascript as it increases the amount of time before the page is ready. If you are going to throw in rel="external" you might as well do target. (In fact, you don't even need rel="external" as you can scan the domain for each link with javascript on the fly.) But I assure you that target will be supported in browsers ten years from now, maybe even twenty. People who insist on perfect validation need to find more productive things to do with their time, there's alot of code out there that needs to be written! ;-) </p> <p>Throw off the shackles of validation!<br /> (I need that as a bumper sticker) </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-20621 Tue, 11 Nov 2008 19:19:23 +0000 lstelie 20621@http://bbpress.org/forums/ <p>Hello,</p> <p>I use for a pretty long time rel="external" more compliant and this works well.</p> <p>The following bit of code is from</p> <p><a href="http://www.sitepoint.com/article/standards-compliant-world" rel="nofollow">http://www.sitepoint.com/article/standards-compliant-world</a></p> <pre><code>function externalLinks() { if (!document.getElementsByTagName) return; var anchors = document.getElementsByTagName(&quot;a&quot;); for (var i=0; i&lt;anchors.length; i++) { var anchor = anchors[i]; if (anchor.getAttribute(&quot;href&quot;) &#38;&#38; anchor.getAttribute(&quot;rel&quot;) == &quot;external&quot;) anchor.target = &quot;_blank&quot;; } } window.onload = externalLinks;</code></pre> <p>If JS is not activated ? well no external link but the site is prefectly working </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-20620 Tue, 11 Nov 2008 18:29:11 +0000 TrishaM 20620@http://bbpress.org/forums/ <p>This worked perfectly! I deactivated the bb_tweaks plugin so as to not cause any conflict (I think I only installed it for the target="_blank function) but in theory if I wanted to have it activated as well, I would just need to comment out the function for bb_target_blank, correct?</p> <p>Thanks so much for this! </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-20612 Tue, 11 Nov 2008 14:01:38 +0000 _ck_ 20612@http://bbpress.org/forums/ <p>Okay this one is testing working.<br /> For anyone else that wants to use this, you have to replace the domain name by hand. It's hardcoded for speed, sorry.</p> <p>All other target="_blank" plugins should be uninstalled. Any existing links with target="_blank" will be left in place for performance since target is not added by bbPress by default.</p> <pre><code>&lt;?php /* Plugin Name: Target Nofollow External Only Description: append target=&quot;_blank&quot; and rel=&quot;nofollow&quot; only on external links Plugin URI: Author: _ck_ Version: 0.0.1 */ add_filter(&#39;post_text&#39;, &#39;target_nofollow_external_only&#39;,999); // unfortunately we have to do this on every page load and not in pre_post function target_nofollow_external_only( $text ) { $domain=&quot;travel\-writers\-exchange\.com&quot;; // domain to exclude from target and nofollow $text = preg_replace(&#39;|&lt;a (.*)rel=[\&#39;&quot;]nofollow[\&#39;&quot;](.+)?&gt;|iU&#39;,&#39;&lt;a &gt;&#39;, $text); // strip ALL nofollow $text = preg_replace(&#39;|&lt;a (?=([^&gt;]+http\:\/\/))(?!([^&gt;]+&#39;.$domain.&#39;))(.+)&gt;|iU&#39;, &#39;&lt;a rel=&quot;nofollow&quot; target=&quot;_blank&quot;&gt;&#39;, $text); // add back in when needed return $text; } ?&gt;</code></pre> <p><em> </em><br /> I'm not happy about the performance of this technique because it has to be done in post_text for every time a page is displayed, but there's no other easy way around bbPress/WordPress's unfortunate use of make_clickable with hardcoded "nofollow" in post_text. </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-20611 Tue, 11 Nov 2008 12:25:23 +0000 _ck_ 20611@http://bbpress.org/forums/ <p>Okay I'll play with it some more and see what I can do.</p> <p>update: the problem lies within make_clickable which has nofollow hard coded and impossible to "unfilter" at that level</p> <p>I'll have to come up with a way to do it at display time and cleanup the mess bbpress (actually wordpress functions) create </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-20605 Mon, 10 Nov 2008 20:26:13 +0000 TrishaM 20605@http://bbpress.org/forums/ <p>Hmmm.....okay well I did add this code to bb_tweaks......I replaced the function bb_target_blank section with what you have here, and I removed the <code>add_filter(&#39;pre-post&#39;,&#39;bb_rel_nofollow&#39;);</code> and added the remove_filter actions above.......but it did not seem to have any effect - bbPress still strips out any "target" reference and still adds the rel="nofollow" to all links.....</p> <p>I haven't made any other tweaks to this.... </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-20582 Sun, 09 Nov 2008 17:59:17 +0000 _ck_ 20582@http://bbpress.org/forums/ <p>Well we could cheat and make the plugin skip links that have your domain name or no <code><a href="http://" rel="nofollow">http://</a></code> in it.</p> <pre><code>function bb_target_blank( $text ) { $text = preg_replace(&#39;|&lt;a (?=http\:\/\/)(?!travel\-writers\-exchange\.com)(.+?)&gt;|i&#39;, &#39;&lt;a rel=&quot;nofollow&quot; target=&quot;_blank&quot;&gt;&#39;, $text); return $text; }</code></pre> <p>This is untested.<br /> It's a fancy regex feature called negative lookahead.<br /> Try it and see what happens.</p> <p>Doing nofollow for only externals is essentially the same thing, I've added it to the replacement above.Make sure you have no additional tweaks for nofollow. I don't think it's on by default? If so, try </p> <pre><code>remove_filter(&#39;post_text&#39;, &#39;bb_rel_nofollow&#39;); remove_filter(&#39;pre_post&#39;, &#39;bb_rel_nofollow&#39;);</code></pre> http://bbpress.org/forums/topic/open-links-in-new-window#post-20581 Sun, 09 Nov 2008 17:55:41 +0000 TrishaM 20581@http://bbpress.org/forums/ <p>Thanks _ck_ - that's a good suggestion - I'll play around with that a bit.....maybe I can even find some javascript to get rid of the "rel="nofollow"" on our internal links, as we do want internal links followed...... </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-20579 Sun, 09 Nov 2008 17:51:01 +0000 _ck_ 20579@http://bbpress.org/forums/ <p>updated, see below </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-20578 Sun, 09 Nov 2008 17:47:37 +0000 TrishaM 20578@http://bbpress.org/forums/ <p>Bump - I know this may wind up being a dead issue (at least until a future bbPress update), but is anyone aware of any plugin to give greater control over how links are handled?</p> <p>I don't want to dig into the core files, but I need to have internal links handled differently from external links, and need to be able to not have manually entered links (not using the URL button) altered to remove or add anything to the <code>&lt;a&gt;</code>tag.....so I'm hoping a plugin exists that will allow for link customization.... </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-20452 Tue, 04 Nov 2008 22:00:45 +0000 TrishaM 20452@http://bbpress.org/forums/ <p>I actually have a closely related but slightly different need - I need bbPress to NOT strip out the target if I manually enter it into an <code>&lt;a&gt;</code> tag and, ideally, to also not strip out the rel="nofollow"</p> <p>This plugin does add the rel="nofollow" to links, but I wouldn't want that added to my internal links, just external ones. But it is not adding the target="_blank" and bbPress is still stripping it if I add it manually. Again, I wouldn't want it added for internal links, just external (we want ALL internal (on-site) links to open in the same window, but want ALL external links to open in a new window). </p> <p>The only way I know of to get this granularity of control is to do them manually, but dang it bbPress keeps removing them.</p> <p>I agree totally that it's not good to mess with core files, and I try to avoid it at all costs, but this is a very important issue for us - so if there is no plugin to add this level of control, how can I modify my file(s) to do this? I would happily add a functions.php to my theme and put it there, but am not a good enough coder to write this function myself.</p> <p>Any suggestions? </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-19839 Sat, 11 Oct 2008 20:23:22 +0000 zigx 19839@http://bbpress.org/forums/ <p>anyone know if this plugin works with the latest bbpress? (0.9.0.2 )</p> <p>I cant seem to get it to work.</p> <p>Plugin is activated, but links do not have _blank added into the &lt;a tag.</p> <p>any ideas? thank you!! </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-17938 Sun, 03 Aug 2008 18:27:29 +0000 Anonymous 17938@http://bbpress.org/forums/ <p>thanks Chrishajer:</p> <p>the opposition is that I'm not really develloper, I'm administrator systems but I like to program my website, but I have to tell you that I'm very happy to have bbpress forum in my web, but I had thought that inserting the 'polemical' target in question ) thought my forum will be completly perfect. Anyway...<br /> Well, thank you to try to help me , I'm very gratefull to know you.</p> <p>Thank you very much, I will visit this web frecuently to see more ..</p> <p>Sincerelly , thank you sir. </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-17917 Sun, 03 Aug 2008 12:09:29 +0000 chrishajer 17917@http://bbpress.org/forums/ <p>What you are asking for is best done with a plugin as described. I'm not sure which core files would need to be modified and I wouldn't recommend that anyway. What is the opposition to using a plugin? </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-17912 Sun, 03 Aug 2008 10:19:47 +0000 Anonymous 17912@http://bbpress.org/forums/ <p>thank you Chrishajer: Excus me my bad english , I hope to explain better now:</p> <p>I know that it's a bad idea to modify some bbPress files , I know , I know. But my question is that I think I can insert the 'target="_blank" ' tag in the place qhere the php engine reads the user comment and shows it and the url link goes to a new window explorer.</p> <p>you can see the exemple in my web, and I would like this link works in another window. Click on "BIENVENIDOS AL FORO !!!! " and see the third comment of " jcvandamm Admin Principal and there's some url link:<br /> "</p> <p><a href="http://www.capsir.es/rafa/forum/" rel="nofollow">http://www.capsir.es/rafa/forum/</a></p> <p>thanks for your help and if you can tell me something, please, sincerelly do it: </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-17850 Thu, 31 Jul 2008 19:10:55 +0000 chrishajer 17850@http://bbpress.org/forums/ <p>I'm sorry, I don't understand the question. This won't be in a template file, and it's a bad idea to modify core files, which is why the best practice is to use a function as was posted here. </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-17845 Thu, 31 Jul 2008 16:47:43 +0000 Anonymous 17845@http://bbpress.org/forums/ <p>Thanks for the help, I knew it, but I would like to insert my 'target="_blank" ' in the file Adapted place to see the coments with url added , and of course, I would they works. My question is:<br /> which file is it? (load.php, post.php, target.php)<br /> or , better, which function ?</p> <p>thank you again </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-15673 Tue, 22 Apr 2008 15:37:20 +0000 chrishajer 15673@http://bbpress.org/forums/ <p>&gt; shackles of validation</p> <p>Most awesome quote of the day! </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-15671 Tue, 22 Apr 2008 15:33:30 +0000 _ck_ 15671@http://bbpress.org/forums/ <p>TARGET is deprecated?!<br /> Throw off your shackles of validation, seriously.</p> <p>I promise you that browsers 10+ years from now will still support TARGET. I'll take html over likely-blocked javascript code anyday. At least firefox can intercept the TARGET and open it as a tab which is the user-prefered behavior. </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-15649 Tue, 22 Apr 2008 05:10:28 +0000 chrishajer 15649@http://bbpress.org/forums/ <p><strong>jaydedman</strong></p> <p>I think my dislike of it started when tabbed browsers came around. There is no <code>target=&quot;_newtab&quot;</code>, and I want to control where the windows open. If I want it in a new tab or new window, I do that with my browser. Let me control it rather than specifying where it happens.</p> <p>I dislike it more on some days than others, not as much as I dislike &lt;marquee&gt; and &lt;blink&gt;, but I still tend to dislike it. It's just a personal preference though. Here's something related with a couple discussions linked to it:</p> <p><a href="http://www.456bereastreet.com/archive/200603/the_target_attribute_and_opening_new_windows/" rel="nofollow">http://www.456bereastreet.com/archive/200603/the_target_attribute_and_opening_new_windows/</a> </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-15644 Tue, 22 Apr 2008 02:03:53 +0000 sambauers 15644@http://bbpress.org/forums/ <p>@chrishajer</p> <p>Luckily the sort of people who turn off javascript also happen to be the sort of people who hate having new windows forced on them. :)</p> <p>@jaydedman</p> <p>I agree with chrishajer that forcing new windows is bad. If I want a new window or tab then I can make that happen myself. But when a new window is forced on me I can't make it not do it. </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-15642 Tue, 22 Apr 2008 01:22:22 +0000 jaydedman 15642@http://bbpress.org/forums/ <p>Hey Chris, just wondering why you would think this?<br /> When I'm reading a newspaper article with links, I don't want to be taken out of the article to quickly browse the other link. </p> <p>The same is true for a forum. My main attention is on the thread's conversation, but I may want to browse links that people include when referring to an issue. What I don't want is to be taken out of the thread completely, and need to go back hoping I'll find my place.</p> <p>Anyway, thanks for putting up a possible solution. I'll try it out. </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-15602 Mon, 21 Apr 2008 12:30:27 +0000 chrishajer 15602@http://bbpress.org/forums/ <p>Sam, that won't work with Javascript turned off though, will it? </p> <p>That said, I think opening links in a new window or tab, based on browser configuration, is a bad idea anyway. </p> http://bbpress.org/forums/topic/open-links-in-new-window#post-15597 Mon, 21 Apr 2008 12:02:36 +0000 sambauers 15597@http://bbpress.org/forums/ <p>The target attribute is deprecated (for those who care), use this instead:</p> <pre><code>&lt;?php /* Plugin Name: Links in new window */ //add onclick=&quot;window.open(this.href); return false;&quot; to post links function bb_links _in_new_window( $text ) { $text = preg_replace(&#39;|&lt;a (.+?)&gt;|i&#39;, &#39;&lt;a onclick=&quot;window.open(this.href); return false;&quot;&gt;&#39;, $text); return $text; } add_filter(&#39;pre_post&#39;, &#39;bb_links _in_new_window&#39;); ?&gt;</code></pre> http://bbpress.org/forums/topic/open-links-in-new-window#post-15587 Mon, 21 Apr 2008 05:05:11 +0000 chrishajer 15587@http://bbpress.org/forums/ <p>Courtesy of _ck_ <a href="http://ckon.wordpress.com/2007/07/12/bbpress-plugin-bb-tweaks/" rel="nofollow">http://ckon.wordpress.com/2007/07/12/bbpress-plugin-bb-tweaks/</a></p> <pre><code>&lt;?php /* Plugin Name: Target Blank Description: append target=&quot;_blank&quot; to all links Plugin URI: <a href="http://ckon.wordpress.com/2007/07/12/bbpress-plugin-bb-tweaks/" rel="nofollow">http://ckon.wordpress.com/2007/07/12/bbpress-plugin-bb-tweaks/</a> Author: _ck_ Version: 0.04 */ //add target=_blank to post links function bb_target_blank( $text ) { $text = preg_replace(&#39;|&lt;a (.+?)&gt;|i&#39;, &#39;&lt;a target=&quot;_blank&quot;&gt;&#39;, $text); return $text; } add_filter(&#39;pre_post&#39;, &#39;bb_target_blank&#39;); ?&gt;</code></pre> http://bbpress.org/forums/topic/open-links-in-new-window#post-15583 Mon, 21 Apr 2008 00:26:42 +0000 jaydedman 15583@http://bbpress.org/forums/ <p>I also would like to know the answer to this question. Can anyone say if it's been done before? </p> http://bbpress.org/forums/topic/can-someone-explain-this-bbpress-database-error#post-14463 Fri, 14 Mar 2008 09:04:58 +0000 sambauers 14463@http://bbpress.org/forums/ <p>For some reason in your bbPress installation the quotes aren't being escaped before bbPress tries to enter the post into the database. Differences in character encoding on different platforms may mean it is possible from one platform (pc) and not another (mac).</p> <p>This points to a PHP configuration problem more than anything. Perhpas magic quotes RPC is turned on?</p> <p>Worth digging deeper though. </p> http://bbpress.org/forums/topic/can-someone-explain-this-bbpress-database-error#post-14461 Fri, 14 Mar 2008 07:55:31 +0000 Guru06 14461@http://bbpress.org/forums/ <p>Thank you mettled! I am on a mac and that will explain why none of the other users have said anything about the problem because they are all pc users. let me try the ' here and see what happens </p>